Added Version Info page to toolbar menu

blimp/client/app/android/blimp_client_session_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_APP_ANDROID_BLIMP_CLIENT_SESSION_ANDROID_H_
 #define BLIMP_CLIENT_APP_ANDROID_BLIMP_CLIENT_SESSION_ANDROID_H_
 
 #include "base/android/jni_android.h"
 #include "base/macros.h"
 #include "blimp/client/session/blimp_client_session.h"
@@ skipping 13 matching lines @@
 
   // Methods called from Java via JNI.
   // |jclient_auth_token| is an OAuth2 access token created by GoogleAuthUtil.
   // See BlimpClientSession::Connect() for more information.
   void Connect(JNIEnv* env,
                const base::android::JavaParamRef<jobject>& jobj,
                const base::android::JavaParamRef<jstring>& jclient_auth_token);
 
   void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& jobj);
 
+  base::android::ScopedJavaLocalRef<jstring> GetEngineIPAddress(

[Kevin M, 2016/03/31 19:41:48]

Do we need to break these out into separate fields? I think it might be
advantageous to use a single formatted string instead (e.g. GetEngineInfo()). It
could return a value like "ip:127.0.0.1 version:v51.0.123123" That way, if we
decide to add additional information like as locale info or production zone, we
don't have to poke more holes into JNI.

I can see how having separate fields might be nice for analytics KV pairs, but
if we're just driving a dialog box, then one string seems fine?

[shaktisahu, 2016/04/06 06:50:25]

Acknowledged.

+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& jobj) const;
+  base::android::ScopedJavaLocalRef<jstring> GetEngineVersion(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& jobj) const;
+
  private:
   ~BlimpClientSessionAndroid() override;
 
   // BlimpClientSession implementation.
   void OnAssignmentConnectionAttempted(
       AssignmentSource::Result result) override;
 
   // NetworkEventObserver implementation.
   void OnConnected() override;
   void OnDisconnected(int error_code) override;
 
   // Reference to the Java object which owns this class.
   base::android::ScopedJavaGlobalRef<jobject> java_obj_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpClientSessionAndroid);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_APP_ANDROID_BLIMP_CLIENT_SESSION_ANDROID_H_