Handle null payload when processing an invalidation on Android.

Handle null payload when processing an invalidation on Android.

BUG=599343
Committed: https://crrev.com/276dc49243e685b85adbadf2f63decc0509bd3c3
Cr-Commit-Position: refs/heads/master@{#384988}

[Bernhard Bauer, 2016-03-31 16:41:30]

bauerb@chromium.org changed reviewers:
+ nyquist@chromium.org

[Bernhard Bauer, 2016-03-31 16:41:31]

Please review.

I'm not 100% sure whether the payload is supposed to be null at this point or
not -- there is code in PendingInvalidation that already handles a null payload
(e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/components/invalid...),
but in other places it isn't handled (e.g. equals()). Should those be updated as
well?

[nyquist, 2016-03-31 17:40:35]

I'd update the other places as well. It's retrieved from a bundle, and well...
I'm sure it's possible to get lost in odd cases :-/

[Bernhard Bauer, 2016-03-31 21:15:30]

On 2016/03/31 17:40:35, nyquist wrote:
> I'd update the other places as well. It's retrieved from a bundle, and well...
> I'm sure it's possible to get lost in odd cases :-/

OK. Given that this seems to be a very common crasher (see the number of bugs
duplicated into it), would you be okay with landing this as it is, and I'll
update the other places tomorrow? If so, please LGTM+CQ. Thanks!

[Bernhard Bauer, 2016-04-01 09:34:25]

On 2016/03/31 17:40:35, nyquist wrote:
> I'd update the other places as well. It's retrieved from a bundle, and well...
> I'm sure it's possible to get lost in odd cases :-/

Done. PTAL?

[Bernhard Bauer, 2016-04-04 12:47:09]

On 2016/04/01 09:34:25, Bernhard Bauer wrote:
> On 2016/03/31 17:40:35, nyquist wrote:
> > I'd update the other places as well. It's retrieved from a bundle, and
well...
> > I'm sure it's possible to get lost in odd cases :-/
> 
> Done. PTAL?

Tommy, friendly ping?

[nyquist, 2016-04-04 19:05:24]

lgtm

thanks!

https://codereview.chromium.org/1842393002/diff/80001/components/invalidation...
File
components/invalidation/impl/android/java/src/org/chromium/components/invalidation/PendingInvalidation.java
(right):

https://codereview.chromium.org/1842393002/diff/80001/components/invalidation...
components/invalidation/impl/android/java/src/org/chromium/components/invalidation/PendingInvalidation.java:140:
public int hashCode() {
Does changing the hashCode() have any horrible implications on previously stored
invalidations? Or will this problem just magically go away over time?

[amineer, 2016-04-04 20:10:07]

The CQ bit was checked by amineer@chromium.org

[commit-bot: I haz the power, 2016-04-04 20:10:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842393002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842393002/80001

[commit-bot: I haz the power, 2016-04-04 20:17:36]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-04 20:18:26]

Description was changed from

==========
Handle null payload when processing an invalidation on Android.

BUG=599343
==========

to

==========
Handle null payload when processing an invalidation on Android.

BUG=599343

Committed: https://crrev.com/276dc49243e685b85adbadf2f63decc0509bd3c3
Cr-Commit-Position: refs/heads/master@{#384988}
==========

[commit-bot: I haz the power, 2016-04-04 20:18:26]

Patchset 5 (id:??) landed as
https://crrev.com/276dc49243e685b85adbadf2f63decc0509bd3c3
Cr-Commit-Position: refs/heads/master@{#384988}