Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1842363004: More strong mode fixes for analyzer (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Backout options changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -144 lines) Patch
M pkg/analyzer/lib/src/cancelable_future.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 5 chunks +30 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 4 chunks +7 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/task/model.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/task/model.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 4 chunks +7 lines, -3 lines 0 comments Download
M pkg/analyzer/test/source/error_processor_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/source/package_map_resolver_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/constant/value_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 29 chunks +126 lines, -87 lines 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/inputs_test.dart View 11 chunks +19 lines, -17 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 8 months ago (2016-04-01 15:55:35 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-01 16:13:04 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-04-01 16:35:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6dae827b7051b35086703adfffc47ed663b09926 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698