Expose GrGLAssembleInterface

Expose GrGLAssembleInterface
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842363003

Committed: https://skia.googlesource.com/skia/+/062bd860338dbaa8cae38486a338ea97435aed92

[bsalomon, 2016-03-31 16:07:13]

Description was changed from

==========
Expose GrGLAssembleInterface
==========

to

==========
Expose GrGLAssembleInterface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-31 16:07:47]

bsalomon@google.com changed reviewers:
+ halcanary@google.com, robertphillips@google.com

[hal.canary, 2016-03-31 16:13:32]

On 2016/03/31 16:07:48, bsalomon wrote:

Can GrContext::Create() take a `const GrGLInterface*` as well as an intptr_t?

    static GrContext* Create(GrBackend, const GrGLInterface*);

[robertphillips, 2016-03-31 16:22:11]

lgtm - why are we doing this?

[hal.canary, 2016-03-31 16:28:19]

The new version of SkFiddle (in experimental/fiddle) uses Mesa and links against
the public API only.

[hal.canary, 2016-03-31 16:28:33]

lgtm

[bsalomon, 2016-03-31 16:47:21]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-03-31 16:47:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842363003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842363003/1

[bsalomon, 2016-03-31 16:48:56]

On 2016/03/31 16:13:32, Hal Canary wrote:
> On 2016/03/31 16:07:48, bsalomon wrote:
> 
> Can GrContext::Create() take a `const GrGLInterface*` as well as an intptr_t?
> 
>     static GrContext* Create(GrBackend, const GrGLInterface*);

I plan to make named factories, e.g. sk_sp<GrContext> GrContext::MakeGL(const
GrGLInterface).

For now reinterpret_cast const GrGLInterface* to GrBackendContext.

[commit-bot: I haz the power, 2016-03-31 16:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 16:49:57]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2016-03-31 17:07:52]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-31 17:07:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
halcanary@google.com, robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1842363003/#ps20001
(title: "Fix gpu.gypi")

[commit-bot: I haz the power, 2016-03-31 17:08:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842363003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842363003/20001

[commit-bot: I haz the power, 2016-03-31 17:22:23]

Description was changed from

==========
Expose GrGLAssembleInterface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Expose GrGLAssembleInterface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/062bd860338dbaa8cae38486a338ea97435aed92
==========

[commit-bot: I haz the power, 2016-03-31 17:22:24]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/062bd860338dbaa8cae38486a338ea97435aed92