DescriptionRevert of Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.* (patchset #4 id:60001 of https://codereview.chromium.org/1835673002/ )
Reason for revert:
Prevents clean reverting of an earlier CL (https://codereview.chromium.org/1821923003/) tht cause use after free related to color chooser.
Original issue's description:
> Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*
>
> This CL:
>
> - Moves pixel-capturing code from web_test_proxy_base.* into newly
> created pixel_dump.cc and pixel_dump.h. This helps clean-up
> WebTestProxyBase in preparation for extracting
> view/frame/widget-specific code to separate classes.
>
> - Moves |drag_image_| fields from WebTestProxyBase into TestRunner.
> This also helps clean-up WebTestProxyBase in preparation for
> extracting view/frame/widget-specific code to separate classes.
>
> - Moves |dump_selection_rect| and |dump_drag_image| from TestRunner
> into LayoutTestRuntimeFlags. This makes sure these flags are
> replicated across renderers as needed. This also means that accessors
> for these flags no longer need to be exposed by TestRunner.
>
> - Simplifies how WebTestDelegate communicates devices scaling factor
> (used when positioning a pop-up for pixel dump). This helps
> avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc.
>
> BUG=587175, 595089
>
> Committed: https://crrev.com/bc3216c1723d16c05d88e26e72727a53bbc0c50b
> Cr-Commit-Position: refs/heads/master@{#384109}
TBR=jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=587175, 595089
Committed: https://crrev.com/fd193b305672063bb1620edf134a82fc6edf5e1d
Cr-Commit-Position: refs/heads/master@{#384265}
Patch Set 1 #Messages
Total messages: 5 (1 generated)
|