Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1842353002: Revert of Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.* (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@replicating-accept-languages
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.* (patchset #4 id:60001 of https://codereview.chromium.org/1835673002/ ) Reason for revert: Prevents clean reverting of an earlier CL (https://codereview.chromium.org/1821923003/) tht cause use after free related to color chooser. Original issue's description: > Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.* > > This CL: > > - Moves pixel-capturing code from web_test_proxy_base.* into newly > created pixel_dump.cc and pixel_dump.h. This helps clean-up > WebTestProxyBase in preparation for extracting > view/frame/widget-specific code to separate classes. > > - Moves |drag_image_| fields from WebTestProxyBase into TestRunner. > This also helps clean-up WebTestProxyBase in preparation for > extracting view/frame/widget-specific code to separate classes. > > - Moves |dump_selection_rect| and |dump_drag_image| from TestRunner > into LayoutTestRuntimeFlags. This makes sure these flags are > replicated across renderers as needed. This also means that accessors > for these flags no longer need to be exposed by TestRunner. > > - Simplifies how WebTestDelegate communicates devices scaling factor > (used when positioning a pop-up for pixel dump). This helps > avoid adding a WebTestDelegate dependency to pixel_dump.h/.cc. > > BUG=587175, 595089 > > Committed: https://crrev.com/bc3216c1723d16c05d88e26e72727a53bbc0c50b > Cr-Commit-Position: refs/heads/master@{#384109} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587175, 595089 Committed: https://crrev.com/fd193b305672063bb1620edf134a82fc6edf5e1d Cr-Commit-Position: refs/heads/master@{#384265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -340 lines) Patch
M components/test_runner/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/test_runner/layout_dump.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/test_runner/layout_test_runtime_flags.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/test_runner/layout_test_runtime_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D components/test_runner/pixel_dump.h View 1 chunk +0 lines, -40 lines 0 comments Download
D components/test_runner/pixel_dump.cc View 1 chunk +0 lines, -203 lines 0 comments Download
M components/test_runner/test_runner.h View 7 chunks +13 lines, -11 lines 0 comments Download
M components/test_runner/test_runner.cc View 10 chunks +19 lines, -46 lines 0 comments Download
M components/test_runner/test_runner.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/test_runner/web_test_proxy.h View 4 chunks +16 lines, -1 line 0 comments Download
M components/test_runner/web_test_proxy.cc View 5 chunks +178 lines, -2 lines 0 comments Download
M components/test_runner/web_test_runner.h View 3 chunks +0 lines, -12 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Łukasz Anforowicz
Created Revert of Moving pixel-capturing code from web_test_proxy_base.* into pixel_dump.*
4 years, 8 months ago (2016-03-31 14:05:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842353002/1
4 years, 8 months ago (2016-03-31 14:05:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 14:06:05 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 14:07:29 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd193b305672063bb1620edf134a82fc6edf5e1d
Cr-Commit-Position: refs/heads/master@{#384265}

Powered by Google App Engine
This is Rietveld 408576698