Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/script_view.dart

Issue 184233007: Refactor Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/script_view.dart
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart b/runtime/bin/vmservice/client/lib/src/elements/script_view.dart
similarity index 68%
rename from runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart
rename to runtime/bin/vmservice/client/lib/src/elements/script_view.dart
index 9125fc8124fc0602e6bcab2eda26ff851a6ededf..7d04c2bcf034981e9ec8e16a2e3475c9342b48ac 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/script_view.dart
@@ -5,15 +5,17 @@
library script_view_element;
import 'dart:html';
-import 'package:logging/logging.dart';
+import 'isolate_element.dart';
+import 'package:observatory/app.dart';
import 'package:polymer/polymer.dart';
-import 'observatory_element.dart';
/// Displays an Error response.
@CustomTag('script-view')
-class ScriptViewElement extends ObservatoryElement {
+class ScriptViewElement extends IsolateElement {
@published Script script;
+ ScriptViewElement.created() : super.created();
+
String hitsStyle(ScriptLine line) {
if (line.hits == -1) {
return 'min-width:32px;';
@@ -24,14 +26,7 @@ class ScriptViewElement extends ObservatoryElement {
}
void refreshCoverage(Event e, var detail, Node target) {
- var isolateId = app.locationManager.currentIsolateId();
- var isolate = app.isolateManager.getIsolate(isolateId);
- if (isolate == null) {
- Logger.root.info('No isolate found.');
- return;
- }
- var request = '/$isolateId/coverage';
- app.requestManager.requestMap(request).then((Map coverage) {
+ isolate.getMap('coverage').then((Map coverage) {
assert(coverage['type'] == 'CodeCoverage');
isolate.updateCoverage(coverage['coverage']);
notifyPropertyChange(#hitsStyle, "", hitsStyle);
@@ -40,5 +35,5 @@ class ScriptViewElement extends ObservatoryElement {
});
}
- ScriptViewElement.created() : super.created();
-}
+
+}

Powered by Google App Engine
This is Rietveld 408576698