Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

Issue 184233007: Refactor Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart b/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart
similarity index 88%
rename from runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart
rename to runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart
index 74db7e08333c118f3fa105a881ef948f9c579163..a5537a015559427d17c0a0b2e9a4caf491e9d670 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart
@@ -6,11 +6,8 @@ library observatory_element;
import 'dart:math';
import 'package:polymer/polymer.dart';
-import 'package:observatory/observatory.dart';
-export 'package:observatory/observatory.dart';
-/// Base class for all custom elements. Holds an observable
-/// [ObservableApplication] and applies author styles.
+/// Base class for all Observatory custom elements.
@CustomTag('observatory-element')
class ObservatoryElement extends PolymerElement {
ObservatoryElement.created() : super.created();
@@ -23,13 +20,10 @@ class ObservatoryElement extends PolymerElement {
super.leftView();
}
- void attributeChanged(String name, String oldValue, String newValue) {
+ void attributeChanged(String name, var oldValue, var newValue) {
super.attributeChanged(name, oldValue, newValue);
}
- @published ObservatoryApplication app;
- void appChanged(oldValue) {
- }
bool get applyAuthorStyles => true;
static String _zeroPad(int value, int pad) {
@@ -92,7 +86,7 @@ class ObservatoryElement extends PolymerElement {
String fileAndLine(Map frame) {
var file = frame['script']['user_name'];
var shortFile = file.substring(file.lastIndexOf('/') + 1);
- return "${shortFile}:${frame['line']}";
+ return "${shortFile}:${frame['line']}";
}
bool isNullRef(String type) {

Powered by Google App Engine
This is Rietveld 408576698