Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/message_viewer.dart

Issue 184233007: Refactor Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/message_viewer.dart
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart b/runtime/bin/vmservice/client/lib/src/elements/message_viewer.dart
similarity index 76%
rename from runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart
rename to runtime/bin/vmservice/client/lib/src/elements/message_viewer.dart
index 1899e7c2fed89ed357686b5ac84264ec21e15719..9979d7a49cdc383bb33e6efac9f028db0f05421c 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/message_viewer.dart
@@ -5,6 +5,7 @@
library message_viewer_element;
import 'package:logging/logging.dart';
+import 'package:observatory/app.dart';
import 'package:polymer/polymer.dart';
import 'observatory_element.dart';
@@ -12,12 +13,16 @@ import 'observatory_element.dart';
class MessageViewerElement extends ObservatoryElement {
Map _message;
@published Map get message => _message;
+ @published ObservatoryApplication app;
@published set message(Map m) {
+ if (m == null) {
+ Logger.root.info('Viewing null message.');
+ return;
+ }
+ Logger.root.info('Viewing message of type \'${m['type']}\'');
_message = m;
notifyPropertyChange(#messageType, "", messageType);
- notifyPropertyChange(#members, [], members);
- Logger.root.info('Viewing message of type \'${message['type']}\'');
}
MessageViewerElement.created() : super.created();
@@ -28,11 +33,4 @@ class MessageViewerElement extends ObservatoryElement {
}
return message['type'];
}
-
- List<Map> get members {
- if (message == null || message['members'] == null) {
- return [];
- }
- return message['members'];
- }
}

Powered by Google App Engine
This is Rietveld 408576698