runtime/bin/vmservice/client/lib/src/elements/library_view.dart - Issue 184233007: Refactor Observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/library_view.dart

Issue 184233007: Refactor Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/library_ref.html ('k') | runtime/bin/vmservice/client/lib/src/elements/library_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/elements/library_view.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.dart b/runtime/bin/vmservice/client/lib/src/elements/library_view.dart

similarity index 74%

rename from runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.dart

rename to runtime/bin/vmservice/client/lib/src/elements/library_view.dart

index 05096ded8d8fee779abf862beeb567c49198e6b3..08e23d3a2abd131848a6ebcea4ed5f0a74c816e9 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.dart

+++ b/runtime/bin/vmservice/client/lib/src/elements/library_view.dart

@@ -4,19 +4,18 @@

library library_view_element;

+import 'isolate_element.dart';

import 'package:logging/logging.dart';

import 'package:polymer/polymer.dart';

-import 'observatory_element.dart';

@CustomTag('library-view')

-class LibraryViewElement extends ObservatoryElement {

+class LibraryViewElement extends IsolateElement {

@published Map library = toObservable({});

LibraryViewElement.created() : super.created();

void refresh(var done) {

- var url = app.locationManager.currentIsolateRelativeLink(library['id']);

- app.requestManager.requestMap(url).then((map) {

+ isolate.getMap(library['id']).then((map) {

library = map;

}).catchError((e, trace) {

Logger.root.severe('Error while refreshing library-view: $e\n$trace');