Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html

Issue 184233007: Refactor Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html b/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html
similarity index 79%
rename from runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html
rename to runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html
index be9da98bfdfd2d505bbbdecc2ab5c135d901fdbd..62b6c83ef40041d0d87dc2f12f15f84b8bd22a62 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html
+++ b/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html
@@ -3,7 +3,7 @@
<link rel="import" href="observatory_element.html">
<link rel="import" href="script_ref.html">
</head>
-<polymer-element name="isolate-summary" extends="observatory-element">
+<polymer-element name="isolate-summary" extends="isolate-element">
<template>
<div class="row">
<div class="col-md-1">
@@ -17,7 +17,7 @@
<div class="row">
<template if="{{ isolate.entry['id'] != null }}">
- <a href="{{ app.locationManager.relativeLink(isolate.id, isolate.entry['id']) }}">
+ <a href="{{ isolate.hashLink(isolate.entry['id']) }}">
{{ isolate.name }}
</a>
</template>
@@ -28,9 +28,9 @@
<div class="row">
<small>
- (<a href="{{ app.locationManager.relativeLink(isolate.id, isolate.rootLib) }}">library</a>)
- (<a href="{{ app.locationManager.relativeLink(isolate.id, 'debug/breakpoints') }}">breakpoints</a>)
- (<a href="{{ app.locationManager.relativeLink(isolate.id, 'profile') }}">profile</a>)
+ (<a href="{{ isolate.hashLink(isolate.rootLib) }}">library</a>)
+ (<a href="{{ isolate.hashLink('debug/breakpoints') }}">breakpoints</a>)
+ (<a href="{{ isolate.hashLink('profile') }}">profile</a>)
</small>
</div>
</div>
@@ -63,7 +63,7 @@
</div>
</div>
<div class="col-md-2">
- <a href="{{ app.locationManager.relativeLink(isolate.id, 'allocationprofile') }}">
+ <a href="{{ isolate.hashLink('allocationprofile') }}">
{{ isolate.newHeapUsed | formatSize }}/{{ isolate.oldHeapUsed | formatSize }}
</a>
</div>
@@ -74,7 +74,7 @@
<template if="{{ isolate.topFrame != null }}">
run
</template>
- ( <a href="{{ app.locationManager.relativeLink(isolate.id, 'stacktrace') }}">stack trace</a> )
+ ( <a href="{{ isolate.hashLink('stacktrace') }}">stack trace</a> )
</div>
</div>
<div class="row">
@@ -82,9 +82,9 @@
</div>
<div class="col-md-6">
<template if="{{ isolate.topFrame != null }}">
- <function-ref app="{{ app }}" isolate="{{ isolate }}"
+ <function-ref isolate="{{ isolate }}"
ref="{{ isolate.topFrame['function'] }}"></function-ref>
- (<script-ref app="{{ app }}" isolate="{{ isolate }}"
+ (<script-ref isolate="{{ isolate }}"
ref="{{ isolate.topFrame['script'] }}"
line="{{ isolate.topFrame['line'] }}"></script-ref>)
<br>

Powered by Google App Engine
This is Rietveld 408576698