runtime/bin/vmservice/client/lib/src/elements/instance_ref.dart - Issue 184233007: Refactor Observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/instance_ref.dart

Issue 184233007: Refactor Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/img/isolate_icon.png ('k') | runtime/bin/vmservice/client/lib/src/elements/instance_ref.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/elements/instance_ref.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart b/runtime/bin/vmservice/client/lib/src/elements/instance_ref.dart

similarity index 80%

rename from runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart

rename to runtime/bin/vmservice/client/lib/src/elements/instance_ref.dart

index e305c18a60de69c2ac92c6fff06abd867cae4163..255f041725ed20c05e4852b4663ff2bd13e77cf2 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart

+++ b/runtime/bin/vmservice/client/lib/src/elements/instance_ref.dart

@@ -27,12 +27,10 @@ class InstanceRefElement extends ServiceRefElement {

void expandEvent(bool expand, var done) {

print("Calling expandEvent");

if (expand) {

- app.requestManager.requestMap(url).then((map) {

- print("Result is : $map");

- ref['fields'] = map['fields'];

- ref['elements'] = map['elements'];

- ref['length'] = map['length'];

- print("ref is $ref");

+ isolate.getMap(objectId).then((map) {

+ ref['fields'] = map['fields'];

+ ref['elements'] = map['elements'];

+ ref['length'] = map['length'];

}).catchError((e, trace) {

Logger.root.severe('Error while expanding instance-ref: $e\n$trace');

}).whenComplete(done);