runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.dart - Issue 184233007: Refactor Observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.dart

Issue 184233007: Refactor Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.html ('K') | « runtime/bin/vmservice/client/lib/src/observatory_elements/response_viewer.html ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart » ('j') | runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.dart

index 05bf87ab45106ebbef52a3a813b1d87c759456b3..2dd120e8c11843b572b622bf753a1165139aad2e 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.dart

@@ -11,16 +11,11 @@ import 'service_ref.dart';

class ScriptRefElement extends ServiceRefElement {

@published int line = -1;

- String get url {

- if ((app != null) && (ref != null)) {

- var baseUrl = relativeLink(ref['id']);

- if (line < 0) {

- return baseUrl;

- } else {

- return '$baseUrl?line=$line';

- }

+ String get objectId {

+ if (line < 0) {

+ return super.objectId;

}

- return '';

+ return '${super.objectId}?line=$line';

turnidge 2014/03/05 21:02:47 Maybe put a TODO here to revisit how we are doing

Cutch 2014/03/05 21:54:23 Done.

}

String get hoverText {