Refactor Observatory

runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library isolate_profile_element;
 
 import 'dart:html';
+import 'isolate_element.dart';
 import 'package:logging/logging.dart';
-import 'package:observatory/observatory.dart';
+import 'package:observatory/app.dart';
 import 'package:polymer/polymer.dart';
-import 'observatory_element.dart';
 
 class ProfileCallerTreeRow extends TableTreeRow {
   final Isolate isolate;
   @observable final Code code;
 
   static String formatPercent(num a, num total) {
     var percent = 100.0 * (a / total);
     return '${percent.toStringAsFixed(2)}%';
   }
 
@@ skipping 26 matching lines @@
       children.add(row);
     });
   }
 
   void onHide() {
   }
 }
 
 /// Displays an IsolateProfile
 @CustomTag('isolate-profile')
-class IsolateProfileElement extends ObservatoryElement {
+class IsolateProfileElement extends IsolateElement {
   IsolateProfileElement.created() : super.created();
   @observable int methodCountSelected = 0;
   final List methodCounts = [10, 20, 50];
   @observable List topExclusiveCodes = toObservable([]);
   final _id = '#tableTree';
   TableTree tree;
+  @published Map profile;
+
+  void profileChanged(oldValue) {
+    if (profile == null) {
+      return;
+    }
+    print('profile changed');
+    var samples = profile['samples'];
+    _loadProfileData(isolate, samples, profile);
+    _refresh(isolate);
+  }
 
   void enteredView() {
-    var isolateId = app.locationManager.currentIsolateId();
-    var isolate = app.isolateManager.getIsolate(isolateId);
-    if (isolate == null) {
-      return;
-    }
     tree = new TableTree(['Method', 'Exclusive', 'Caller', 'Inclusive']);
     _refresh(isolate);
   }
 
-  void _startRequest() {
-    // TODO(johnmccutchan): Indicate visually.
-  }
-
-  void _endRequest() {
-    // TODO(johnmccutchan): Indicate visually.
-  }
-
   methodCountSelectedChanged(oldValue) {
-    var isolateId = app.locationManager.currentIsolateId();
-    var isolate = app.isolateManager.getIsolate(isolateId);
-    if (isolate == null) {
-      return;
-    }
     _refresh(isolate);
   }
 
   void refresh(var done) {
-    var isolateId = app.locationManager.currentIsolateId();
-    var isolate = app.isolateManager.getIsolate(isolateId);
-    if (isolate == null) {
-      Logger.root.info('No isolate found.');
-      return;
-    }
-    var request = '/$isolateId/profile';
-    _startRequest();
-    app.requestManager.requestMap(request).then((Map profile) {
+    isolate.getMap('profile').then((Map profile) {
       assert(profile['type'] == 'Profile');
       var samples = profile['samples'];
       Logger.root.info('Profile contains ${samples} samples.');
       _loadProfileData(isolate, samples, profile);
-      _endRequest();
-    }).catchError((e) {
-      _endRequest();
+    }).catchError((e, st) {
+      Logger.root.warning('Error refreshing profile', e, st);
     }).whenComplete(done);
   }
 
   void _loadProfileData(Isolate isolate, int totalSamples, Map response) {
     isolate.profile = new Profile.fromMap(isolate, response);
     _refresh(isolate);
   }
 
   void _refresh(Isolate isolate) {
     _refreshTopMethods(isolate);
@@ skipping 32 matching lines @@
   }
 
   @observable void toggleExpanded(Event e, var detail, Element target) {
     var row = target.parent;
     if (row is TableRowElement) {
       // Subtract 1 to get 0 based indexing.
       tree.toggle(row.rowIndex - 1);
     }
   }
 }