runtime/bin/vmservice/client/lib/src/elements/field_view.html - Issue 184233007: Refactor Observatory

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/field_view.html

Issue 184233007: Refactor Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/field_view.dart ('k') | runtime/bin/vmservice/client/lib/src/elements/function_ref.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <head>	1 <head>

2 <link rel="import" href="class_ref.html">	2 <link rel="import" href="class_ref.html">

3 <link rel="import" href="nav_bar.html">	3 <link rel="import" href="nav_bar.html">

4 <link rel="import" href="observatory_element.html">	4 <link rel="import" href="observatory_element.html">

5 </head>	5 </head>

6 <polymer-element name="field-view" extends="observatory-element">	6 <polymer-element name="field-view" extends="isolate-element">

7 <template>	7 <template>

8 <nav-bar>	8 <nav-bar>

9 <top-nav-menu></top-nav-menu>	9 <top-nav-menu></top-nav-menu>

10 <isolate-nav-menu app="{{ app }}" isolate="{{ app.locationManager.currentI solate() }}">	10 <isolate-nav-menu isolate="{{ isolate }}"></isolate-nav-menu>

11 </isolate-nav-menu>

12 <template if="{{ field['owner']['type'] == '@Class' }}">	11 <template if="{{ field['owner']['type'] == '@Class' }}">

13 <!-- TODO(turnidge): Add library nav menu here. -->	12 <!-- TODO(turnidge): Add library nav menu here. -->

14 <class-nav-menu app="{{ app }}" cls="{{ field['owner'] }}"></class-nav-m enu>	13 <class-nav-menu isolate="{{ isolate }}" cls="{{ field['owner'] }}"></cla ss-nav-menu>

15 </template>	14 </template>

16 <template if="{{ field['owner']['type'] == '@Library' }}">	15 <template if="{{ field['owner']['type'] == '@Library' }}">

17 <library-nav-menu app="{{ app }}" library="{{ field['owner'] }}"></libra ry-nav-menu>	16 <library-nav-menu isolate="{{ isolate }}" library="{{ field['owner'] }}" ></library-nav-menu>

18 </template>	17 </template>

19 <nav-menu link="." anchor="{{ field['user_name'] }}" last="{{ true }}"></n av-menu>	18 <nav-menu link="." anchor="{{ field['user_name'] }}" last="{{ true }}"></n av-menu>

20 <nav-refresh callback="{{ refresh }}"></nav-refresh>	19 <nav-refresh callback="{{ refresh }}"></nav-refresh>

21 </nav-bar>	20 </nav-bar>

22	21

23 <div class="row">	22 <div class="row">

24 <div class="col-md-8 col-md-offset-2">	23 <div class="col-md-8 col-md-offset-2">

25 <div class="panel panel-warning">	24 <div class="panel panel-warning">

26 <div class="panel-heading">	25 <div class="panel-heading">

27 <template if="{{ field['static'] }}">static</template>	26 <template if="{{ field['static'] }}">static</template>

28 <template if="{{ field['final'] }}">final</template>	27 <template if="{{ field['final'] }}">final</template>

29 <template if="{{ field['const'] }}">const</template>	28 <template if="{{ field['const'] }}">const</template>

30 {{ field['user_name'] }} ({{ field['name'] }})	29 {{ field['user_name'] }} ({{ field['name'] }})

31 <class-ref app="{{ app }}" ref="{{ field['class'] }}"></class-ref>	30 <class-ref isolate="{{ isolate }}" ref="{{ field['class'] }}"></class- ref>

32 </div>	31 </div>

33 <div class="panel-body">	32 <div class="panel-body">

34 <template if="{{ field['guard_class'] == 'dynamic'}}">	33 <template if="{{ field['guard_class'] == 'dynamic'}}">

35 <div class="alert alert-danger">	34 <div class="alert alert-danger">

36 Field has been assigned multiple types. If a field is only ever	35 Field has been assigned multiple types. If a field is only ever

37 assigned a single type, performance may improve.	36 assigned a single type, performance may improve.

38 </div>	37 </div>

39 </template>	38 </template>

40 <template if="{{ (field['guard_class'] != 'dynamic') && (field['guard_cl ass'] != 'unknown') }}">	39 <template if="{{ (field['guard_class'] != 'dynamic') && (field['guard_cl ass'] != 'unknown') }}">

41 <div class="alert alert-success">Field has monomorphic type</div>	40 <div class="alert alert-success">Field has monomorphic type</div>

42 <template if="{{ (field['guard_class'] != 'dynamic') &&	41 <template if="{{ (field['guard_class'] != 'dynamic') &&

43 field['guard_nullable'] }}">	42 field['guard_nullable'] }}">

44 <div class="alert alert-info">	43 <div class="alert alert-info">

45 Field has been assigned null. If a field is never assigned null,	44 Field has been assigned null. If a field is never assigned null,

46 performance may improve.	45 performance may improve.

47 </div>	46 </div>

48 </template>	47 </template>

49 <blockquote>	48 <blockquote>

50 <class-ref app="{{ app }}" ref="{{ field['guard_class'] }}"></class- ref>	49 <class-ref isolate="{{ isolate }}" ref="{{ field['guard_class'] }}"> </class-ref>

51 </blockquote>	50 </blockquote>

52 </template>	51 </template>

53 </div>	52 </div>

54 </div>	53 </div>

55 </div>	54 </div>

56 </div>	55 </div>

57 </template>	56 </template>

58 <script type="application/dart" src="field_view.dart"></script>	57 <script type="application/dart" src="field_view.dart"></script>

59 </polymer-element>	58 </polymer-element>

OLD	NEW