Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 184233006: Remove RefPtrHashMap (Closed)

Created:
6 years, 9 months ago by Mikhail
Modified:
6 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium, Erik Corry, eseidel, Nico, tkent
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove RefPtrHashMap The recently added 'HashTraits::PeekInType' type allows us to remove HashMap<RefPtr..> template specialization without loosing the efficiency and without bringing any significant changes and complexity to the HashMap class. To get rid of 'RefPtrHashMap' a new 'RefPtrValuePeeker' type was created and used as 'HashTraits::PeekInType' for RefPtr. The 'RefPtrValuePeeker' class can be constructed either from RefPtr, PassRefPtr or a plain pointer, then it behaves like a plain pointer itself within HashTable methods. The proposed change brings the following benefits: 1) Removes tons of duplicated code 2) Allows avoiding ref-count churn also at HashSet<RefPtr> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -334 lines) Patch
M Source/wtf/HashMap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/HashTraits.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/RefPtr.h View 1 chunk +10 lines, -0 lines 0 comments Download
D Source/wtf/RefPtrHashMap.h View 1 chunk +0 lines, -330 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Mikhail
PTAL
6 years, 9 months ago (2014-03-05 14:59:03 UTC) #1
tkent
lgtm
6 years, 9 months ago (2014-03-05 23:12:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/184233006/1
6 years, 9 months ago (2014-03-05 23:13:20 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 23:13:46 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-05 23:13:46 UTC) #5
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 9 months ago (2014-03-06 06:27:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/184233006/1
6 years, 9 months ago (2014-03-06 06:28:10 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 08:08:35 UTC) #8
Message was sent while issue was closed.
Change committed as 168593

Powered by Google App Engine
This is Rietveld 408576698