Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 184233004: Skip 'accessibilityController' property in the cached properties test (Closed)

Created:
6 years, 9 months ago by hajimehoshi
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Skip 'accessibilityController' property in the cached properties test https://codereview.chromium.org/172263002/ moves AccessibilityController from CppBoundClass to gin::Wrappable, and that CL changes this cached- properties test's result so that 'accessibilityController' is enumerated as properties of an object. However, it is hard to expect a stable cache result of WebAXObject of AccessibilityController for now. BUG=297480, 331301, 347331 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168564

Patch Set 1 #

Total comments: 2

Patch Set 2 : haraken's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M LayoutTests/fast/dom/Window/resources/window-property-collector.js View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
hajimehoshi
PTAL
6 years, 9 months ago (2014-03-05 05:43:44 UTC) #1
haraken
LGTM https://codereview.chromium.org/184233004/diff/1/LayoutTests/fast/dom/Window/resources/window-property-collector.js File LayoutTests/fast/dom/Window/resources/window-property-collector.js (right): https://codereview.chromium.org/184233004/diff/1/LayoutTests/fast/dom/Window/resources/window-property-collector.js#newcode67 LayoutTests/fast/dom/Window/resources/window-property-collector.js:67: // Skip the properties which are hard to ...
6 years, 9 months ago (2014-03-05 05:49:26 UTC) #2
kouhei (in TOK)
lgtm
6 years, 9 months ago (2014-03-05 05:49:40 UTC) #3
hajimehoshi
Thank you! https://codereview.chromium.org/184233004/diff/1/LayoutTests/fast/dom/Window/resources/window-property-collector.js File LayoutTests/fast/dom/Window/resources/window-property-collector.js (right): https://codereview.chromium.org/184233004/diff/1/LayoutTests/fast/dom/Window/resources/window-property-collector.js#newcode67 LayoutTests/fast/dom/Window/resources/window-property-collector.js:67: // Skip the properties which are hard ...
6 years, 9 months ago (2014-03-05 05:53:56 UTC) #4
hajimehoshi
The CQ bit was checked by hajimehoshi@chromium.org
6 years, 9 months ago (2014-03-05 05:54:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/184233004/20001
6 years, 9 months ago (2014-03-05 05:55:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/184233004/20001
6 years, 9 months ago (2014-03-05 20:56:02 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 04:05:21 UTC) #8
Message was sent while issue was closed.
Change committed as 168564

Powered by Google App Engine
This is Rietveld 408576698