Fix the issue that it may get wrong stride in cc::ResourceProvider::MapImage.

gpu/command_buffer/client/gles2_implementation.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A class to emulate GLES2 over command buffers.
 
 #include "gpu/command_buffer/client/gles2_implementation.h"
 
 #include <algorithm>
 #include <map>
@@ skipping 3890 matching lines @@
   }
 
   gfx::GpuMemoryBuffer* gpu_buffer = gpu_memory_buffer_tracker_->GetBuffer(
       image_id);
   if (!gpu_buffer) {
     SetGLError(GL_INVALID_OPERATION, "glGetImageParameterivCHROMIUM",
                "invalid image");
     return;
   }
 
+  // In Android, the SurfaceTexture based GpuMemoryBuffer can only get the
+  // exact stride after it is mapped. Here it would be better to ensure that
+  // it maps image first and then calls GetStride().

[reveman, 2014/03/03 16:57:48]

Same thing here. I would prefer no platform/implementation specific details
here.

Actually, I think this should generate a GL_INVALID_OPERATION instead of a
DCHECK failure as it's not an implementation detail but part of the spec.

[junj, 2014/03/04 11:11:23]

Done.

+  DCHECK(gpu_buffer->IsMapped());
   *params = gpu_buffer->GetStride();
 }
 
 void GLES2Implementation::GetImageParameterivCHROMIUM(
     GLuint image_id, GLenum pname, GLint* params) {
   GPU_CLIENT_SINGLE_THREAD_CHECK();
   GPU_CLIENT_VALIDATE_DESTINATION_INITALIZATION(GLint, params);
   GPU_CLIENT_LOG("[" << GetLogPrefix() << "] glImageParameterivCHROMIUM("
       << image_id << ", "
       << GLES2Util::GetStringBufferParameter(pname) << ", "
       << static_cast<const void*>(params) << ")");
   GetImageParameterivCHROMIUMHelper(image_id, pname, params);
   CheckGLError();
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/client/gles2_implementation_impl_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu