Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 1842323002: [DevTools] Fix stale requests in Network panel not being refreshed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add name to AUTHORS file. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 4b7c2d79789fefe86675e9a11a226730c245cf87..0bae0c89c3e4fccb8f04e14152a69a623a02c8d2 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -961,7 +961,10 @@ WebInspector.NetworkLogView.prototype = {
var dataGrid = this._dataGrid;
var rootNode = dataGrid.rootNode();
+ /** @type {!Array<!WebInspector.NetworkDataGridNode> } */
var nodesToInsert = [];
+ /** @type {!Array<!WebInspector.NetworkDataGridNode> } */
+ var nodesToRefresh = [];
for (var requestId in this._staleRequestIds) {
var node = this._nodesByRequestId.get(requestId);
if (!node)
@@ -976,6 +979,8 @@ WebInspector.NetworkLogView.prototype = {
if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
nodesToInsert.push(node);
}
+ if (!isFilteredOut)
+ nodesToRefresh.push(node);
var request = node.request();
this._timeCalculator.updateBoundaries(request);
this._durationCalculator.updateBoundaries(request);
@@ -985,10 +990,12 @@ WebInspector.NetworkLogView.prototype = {
var node = nodesToInsert[i];
var request = node.request();
dataGrid.insertChild(node);
- node.refresh();
node[WebInspector.NetworkLogView._isMatchingSearchQuerySymbol] = this._matchRequest(request);
}
+ for (var node of nodesToRefresh)
+ node.refresh();
+
this._highlightNthMatchedRequestForSearch(this._updateMatchCountAndFindMatchIndex(this._currentMatchedRequestNode), false);
if (!this.calculator().boundary().equals(oldBoundary)) {
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698