[DevTools] Fix stale requests in Network panel not being refreshed

third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 4b7c2d79789fefe86675e9a11a226730c245cf87..fcbb6860595cc5043cfcb8f2239f8a3183b5e8c7 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -962,6 +962,7 @@ WebInspector.NetworkLogView.prototype = {
         var dataGrid = this._dataGrid;
         var rootNode = dataGrid.rootNode();
         var nodesToInsert = [];
+        var nodesToRefresh = [];

[pfeldman, 2016/04/01 17:47:13]

You should annotate this array as !Array<WebInspector.NetworkDataGridNode>. You
can also fix the one above as a drive-by.

[Matt Zeunert, 2016/04/01 18:47:06]

Done.

         for (var requestId in this._staleRequestIds) {
             var node = this._nodesByRequestId.get(requestId);
             if (!node)
@@ -976,6 +977,9 @@ WebInspector.NetworkLogView.prototype = {
                 if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
                     nodesToInsert.push(node);
             }
+            if (!isFilteredOut) {

[pfeldman, 2016/04/01 17:47:13]

This should be in the else branch - otherwise you are pushing the same node both
into nodesToInsert and nodesToRefresh.

[Matt Zeunert, 2016/04/01 18:47:06]

I removed the refresh call from inside the nodesToInsert loop, so the nodes
still need to be refreshed after being inserted.

Otherwise request data won't be updated if the request was filtered out while
the request data changed. By pushing the node into both nodesToInsert and
nodesToRefresh the node will be updated when the filter is removed.

+                nodesToRefresh.push(node);
+            }
             var request = node.request();
             this._timeCalculator.updateBoundaries(request);
             this._durationCalculator.updateBoundaries(request);
@@ -985,10 +989,14 @@ WebInspector.NetworkLogView.prototype = {
             var node = nodesToInsert[i];
             var request = node.request();
             dataGrid.insertChild(node);
-            node.refresh();
             node[WebInspector.NetworkLogView._isMatchingSearchQuerySymbol] = this._matchRequest(request);
         }
 
+        for (var i = 0; i < nodesToRefresh.length; ++i) {
+            var node = nodesToRefresh[i];
+            node.refresh();

[pfeldman, 2016/04/01 17:47:13]

We are now using "for of" for non performance critical code, so you could do:

for (var node of nodesToRefresh)
    node.refresh()

I personally prefer it to forEach since you don't create a new function.

[Matt Zeunert, 2016/04/01 18:47:06]

Done.

+        }
+
         this._highlightNthMatchedRequestForSearch(this._updateMatchCountAndFindMatchIndex(this._currentMatchedRequestNode), false);
 
         if (!this.calculator().boundary().equals(oldBoundary)) {