[DevTools] Fix stale requests in Network panel not being refreshed

third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 944 matching lines @@
 
         var oldBoundary = this.calculator().boundary();
         this._timeCalculator.updateBoundariesForEventTime(this._mainRequestLoadTime);
         this._durationCalculator.updateBoundariesForEventTime(this._mainRequestLoadTime);
         this._timeCalculator.updateBoundariesForEventTime(this._mainRequestDOMContentLoadedTime);
         this._durationCalculator.updateBoundariesForEventTime(this._mainRequestDOMContentLoadedTime);
 
         var dataGrid = this._dataGrid;
         var rootNode = dataGrid.rootNode();
         var nodesToInsert = [];
+        var nodesToRefresh = [];

[pfeldman, 2016/04/01 17:47:13]

You should annotate this array as !Array<WebInspector.NetworkDataGridNode>. You
can also fix the one above as a drive-by.

[Matt Zeunert, 2016/04/01 18:47:06]

Done.

         for (var requestId in this._staleRequestIds) {
             var node = this._nodesByRequestId.get(requestId);
             if (!node)
                 continue;
             var isFilteredOut = !this._applyFilter(node);
             if (node[WebInspector.NetworkLogView._isFilteredOutSymbol] !== isFilteredOut) {
                 if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
                     rootNode.removeChild(node);
 
                 node[WebInspector.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
 
                 if (!node[WebInspector.NetworkLogView._isFilteredOutSymbol])
                     nodesToInsert.push(node);
             }
+            if (!isFilteredOut) {

[pfeldman, 2016/04/01 17:47:13]

This should be in the else branch - otherwise you are pushing the same node both
into nodesToInsert and nodesToRefresh.

[Matt Zeunert, 2016/04/01 18:47:06]

I removed the refresh call from inside the nodesToInsert loop, so the nodes
still need to be refreshed after being inserted.

Otherwise request data won't be updated if the request was filtered out while
the request data changed. By pushing the node into both nodesToInsert and
nodesToRefresh the node will be updated when the filter is removed.

+                nodesToRefresh.push(node);
+            }
             var request = node.request();
             this._timeCalculator.updateBoundaries(request);
             this._durationCalculator.updateBoundaries(request);
         }
 
         for (var i = 0; i < nodesToInsert.length; ++i) {
             var node = nodesToInsert[i];
             var request = node.request();
             dataGrid.insertChild(node);
+            node[WebInspector.NetworkLogView._isMatchingSearchQuerySymbol] = this._matchRequest(request);
+        }
+
+        for (var i = 0; i < nodesToRefresh.length; ++i) {
+            var node = nodesToRefresh[i];
             node.refresh();

[pfeldman, 2016/04/01 17:47:13]

We are now using "for of" for non performance critical code, so you could do:

for (var node of nodesToRefresh)
    node.refresh()

I personally prefer it to forEach since you don't create a new function.

[Matt Zeunert, 2016/04/01 18:47:06]

Done.

-            node[WebInspector.NetworkLogView._isMatchingSearchQuerySymbol] = this._matchRequest(request);
         }
 
         this._highlightNthMatchedRequestForSearch(this._updateMatchCountAndFindMatchIndex(this._currentMatchedRequestNode), false);
 
         if (!this.calculator().boundary().equals(oldBoundary)) {
             // The boundaries changed, so all item graphs are stale.
             this._updateDividersIfNeeded();
             var nodes = this._nodesByRequestId.valuesArray();
             for (var i = 0; i < nodes.length; ++i)
                 nodes[i].refreshGraph();
@@ skipping 1166 matching lines @@
         return false;
     return true;
 }
 
 WebInspector.NetworkLogView.EventTypes = {
     RequestSelected: "RequestSelected",
     SearchCountUpdated: "SearchCountUpdated",
     SearchIndexUpdated: "SearchIndexUpdated",
     UpdateRequest: "UpdateRequest"
 };