Roll Clang 264334:264915

Roll Clang 264334:264915

This picks up upstream CMake changes that remove the need to pass
-fms-compatibility-version=19. Removing that flag also has the side
effect of preserving frame pointers in the ASan runtime. (!)

I have successfully built and uploaded a Windows package, and will
use try jobs to attempt to build and upload Mac and Linux packages.

R=thakis@chromium.org
BUG=598943
Committed: https://crrev.com/58dbc65a7fa88580b84d9438bd8e98706b34aded
Cr-Commit-Position: refs/heads/master@{#384475}

[Reid Kleckner, 2016-03-30 22:47:35]

Description was changed from

==========
# Enter a description of the change.
Roll Clang 264334:264915

This picks up upstream CMake changes that remove the need to pass
-fms-compatibility-version=19. Removing that flag also has the side
effect of preserving frame pointers in the ASan runtime. (!)

I have successfully built and uploaded a Windows package, and will
use try jobs to attempt to build and upload Mac and Linux packages.

R=thakis@chromium.org
BUG=598943
==========

to

==========
Roll Clang 264334:264915

This picks up upstream CMake changes that remove the need to pass
-fms-compatibility-version=19. Removing that flag also has the side
effect of preserving frame pointers in the ASan runtime. (!)

I have successfully built and uploaded a Windows package, and will
use try jobs to attempt to build and upload Mac and Linux packages.

R=thakis@chromium.org
BUG=598943
==========

[Nico, 2016-03-30 23:01:46]

On 2016/03/30 22:47:11, Reid Kleckner wrote:

Mac bot failed with svn prompt :-/

Change lgtm once there are packages that are on goma. If you upload yourself,
make sure to sync your goma checkout, yyanagisawa changed the package script 2
days ago.

Can you summarize why passing MSC version here breaks things but passing it from
upstream cmake doesn't?

[Reid Kleckner, 2016-03-30 23:07:51]

On 2016/03/30 23:01:46, Nico wrote:
> On 2016/03/30 22:47:11, Reid Kleckner wrote:
> 
> Mac bot failed with svn prompt :-/

I tried to fix it, but need chrome-build-access. Hans is working on manually
accepting the cert for now.

> Change lgtm once there are packages that are on goma. If you upload yourself,
> make sure to sync your goma checkout, yyanagisawa changed the package script 2
> days ago.

OK

> Can you summarize why passing MSC version here breaks things but passing it
from
> upstream cmake doesn't?

We were passing that flag to MSVC accidentally. Our script looked like:

cflags = []
cmake $cflags bootstrap
ninja bootstrap 
cflags += [ "-fms-compat" ]
cmake $cflags CC=clang-cl build
ninja build
cmake $cflags compiler-rt # oops used fms-compat with MSVC
ninja build

The upstream cmake doesn't have that bug. By passing an extra cflag that MSVC
didn't understand, we made all check_cxx_compiler_supports_flag checks fail, so
we weren't passing /Oy- to the compiler.

[Reid Kleckner, 2016-03-31 22:35:58]

The CQ bit was checked by rnk@chromium.org

[commit-bot: I haz the power, 2016-03-31 22:36:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842253002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842253002/1

[Nico, 2016-03-31 22:40:12]

was this pushed to goma? i don't see the usual announcement on the goma@ list

[Reid Kleckner, 2016-03-31 22:42:14]

On 2016/03/31 22:40:12, Nico wrote:
> was this pushed to goma? i don't see the usual announcement on the goma@ list

It was, look for 264915-1?

[commit-bot: I haz the power, 2016-04-01 03:28:43]

Description was changed from

==========
Roll Clang 264334:264915

This picks up upstream CMake changes that remove the need to pass
-fms-compatibility-version=19. Removing that flag also has the side
effect of preserving frame pointers in the ASan runtime. (!)

I have successfully built and uploaded a Windows package, and will
use try jobs to attempt to build and upload Mac and Linux packages.

R=thakis@chromium.org
BUG=598943
==========

to

==========
Roll Clang 264334:264915

This picks up upstream CMake changes that remove the need to pass
-fms-compatibility-version=19. Removing that flag also has the side
effect of preserving frame pointers in the ASan runtime. (!)

I have successfully built and uploaded a Windows package, and will
use try jobs to attempt to build and upload Mac and Linux packages.

R=thakis@chromium.org
BUG=598943
==========

[commit-bot: I haz the power, 2016-04-01 03:28:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-01 03:29:47]

Description was changed from

==========
Roll Clang 264334:264915

This picks up upstream CMake changes that remove the need to pass
-fms-compatibility-version=19. Removing that flag also has the side
effect of preserving frame pointers in the ASan runtime. (!)

I have successfully built and uploaded a Windows package, and will
use try jobs to attempt to build and upload Mac and Linux packages.

R=thakis@chromium.org
BUG=598943
==========

to

==========
Roll Clang 264334:264915

This picks up upstream CMake changes that remove the need to pass
-fms-compatibility-version=19. Removing that flag also has the side
effect of preserving frame pointers in the ASan runtime. (!)

I have successfully built and uploaded a Windows package, and will
use try jobs to attempt to build and upload Mac and Linux packages.

R=thakis@chromium.org
BUG=598943

Committed: https://crrev.com/58dbc65a7fa88580b84d9438bd8e98706b34aded
Cr-Commit-Position: refs/heads/master@{#384475}
==========

[commit-bot: I haz the power, 2016-04-01 03:29:48]

Patchset 1 (id:??) landed as
https://crrev.com/58dbc65a7fa88580b84d9438bd8e98706b34aded
Cr-Commit-Position: refs/heads/master@{#384475}