Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1842243002: Update SkImageSource to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 14

Patch Set 3 : Fix leaks #

Patch Set 4 : Fix bug #

Patch Set 5 : Addressed code review issue #

Patch Set 6 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -231 lines) Patch
M bench/DisplacementBench.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M bench/MergeBench.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M gm/bigtileimagefilter.cpp View 1 2 2 chunks +16 lines, -13 lines 0 comments Download
M gm/displacement.cpp View 1 chunk +30 lines, -30 lines 0 comments Download
M gm/filterfastbounds.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 2 3 4 5 4 chunks +42 lines, -43 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersscaled.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M gm/imagefilterstransformed.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/imagesource.cpp View 1 2 3 4 2 chunks +34 lines, -28 lines 0 comments Download
M gm/imagesource2.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M gm/offsetimagefilter.cpp View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M gm/resizeimagefilter.cpp View 1 2 6 chunks +38 lines, -35 lines 0 comments Download
M gm/tileimagefilter.cpp View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M include/effects/SkImageSource.h View 2 chunks +33 lines, -7 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M src/effects/SkImageSource.cpp View 1 2 3 2 chunks +11 lines, -19 lines 0 comments Download
M src/utils/SkBitmapSourceDeserializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 3 4 5 5 chunks +10 lines, -10 lines 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
robertphillips
4 years, 8 months ago (2016-03-31 12:11:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842243002/20001
4 years, 8 months ago (2016-03-31 12:11:55 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 12:21:42 UTC) #8
f(malita)
lgtm https://codereview.chromium.org/1842243002/diff/20001/gm/imagesource.cpp File gm/imagesource.cpp (right): https://codereview.chromium.org/1842243002/diff/20001/gm/imagesource.cpp#newcode19 gm/imagesource.cpp:19: paint.setImageFilter(filter); nit: move filter
4 years, 8 months ago (2016-03-31 12:55:06 UTC) #9
f(malita)
https://codereview.chromium.org/1842243002/diff/20001/src/effects/SkImageSource.cpp File src/effects/SkImageSource.cpp (right): https://codereview.chromium.org/1842243002/diff/20001/src/effects/SkImageSource.cpp#newcode21 src/effects/SkImageSource.cpp:21: , fImage(image) move image? https://codereview.chromium.org/1842243002/diff/20001/src/effects/SkImageSource.cpp#newcode31 src/effects/SkImageSource.cpp:31: , fImage(image) move ...
4 years, 8 months ago (2016-03-31 13:09:15 UTC) #10
f(malita)
https://codereview.chromium.org/1842243002/diff/20001/gm/bigtileimagefilter.cpp File gm/bigtileimagefilter.cpp (right): https://codereview.chromium.org/1842243002/diff/20001/gm/bigtileimagefilter.cpp#newcode60 gm/bigtileimagefilter.cpp:60: p.setImageFilter(SkTileImageFilter::Create(SkRect::MakeIWH(kBitmapSize, kBitmapSize), out-of-order ditto https://codereview.chromium.org/1842243002/diff/20001/gm/bigtileimagefilter.cpp#newcode73 gm/bigtileimagefilter.cpp:73: p2.setImageFilter(SkTileImageFilter::Create(SkRect::MakeIWH(kBitmapSize, kBitmapSize), out-of-order ...
4 years, 8 months ago (2016-03-31 13:26:09 UTC) #11
robertphillips
https://codereview.chromium.org/1842243002/diff/20001/src/effects/SkImageSource.cpp File src/effects/SkImageSource.cpp (right): https://codereview.chromium.org/1842243002/diff/20001/src/effects/SkImageSource.cpp#newcode21 src/effects/SkImageSource.cpp:21: , fImage(image) On 2016/03/31 13:09:15, f(malita) wrote: > move ...
4 years, 8 months ago (2016-03-31 14:35:09 UTC) #12
robertphillips
https://codereview.chromium.org/1842243002/diff/20001/gm/bigtileimagefilter.cpp File gm/bigtileimagefilter.cpp (right): https://codereview.chromium.org/1842243002/diff/20001/gm/bigtileimagefilter.cpp#newcode60 gm/bigtileimagefilter.cpp:60: p.setImageFilter(SkTileImageFilter::Create(SkRect::MakeIWH(kBitmapSize, kBitmapSize), On 2016/03/31 13:26:09, f(malita) wrote: > out-of-order ...
4 years, 8 months ago (2016-03-31 14:35:54 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842243002/60001
4 years, 8 months ago (2016-03-31 14:36:13 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 14:53:12 UTC) #17
robertphillips
https://codereview.chromium.org/1842243002/diff/20001/gm/imagesource.cpp File gm/imagesource.cpp (right): https://codereview.chromium.org/1842243002/diff/20001/gm/imagesource.cpp#newcode19 gm/imagesource.cpp:19: paint.setImageFilter(filter); On 2016/03/31 12:55:06, f(malita) wrote: > nit: move ...
4 years, 8 months ago (2016-03-31 15:03:05 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842243002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842243002/100001
4 years, 8 months ago (2016-03-31 17:59:18 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 18:10:06 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842243002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842243002/100001
4 years, 8 months ago (2016-04-01 16:27:53 UTC) #25
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 16:28:54 UTC) #27
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/549c8991959333e5c0f53faebcbbd5d6bc8f6a56

Powered by Google App Engine
This is Rietveld 408576698