Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 184223007: Fix segments-from-data-url.js to PASS instead of just updating expected FAIL lines. (Closed)

Created:
6 years, 9 months ago by Tom Sepez
Modified:
6 years, 9 months ago
Reviewers:
cbiesinger
CC:
blink-reviews
Visibility:
Public.

Description

Fix segments-from-data-url.js to log PASS instead of just updating expected FAIL lines. R=cbiesinger@chromium.org BUG=346132 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168549

Patch Set 1 #

Patch Set 2 : 500s #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M LayoutTests/fast/url/script-tests/segments-from-data-url.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/android/fast/url/segments-from-data-url-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/url/segments-from-data-url-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/url/segments-from-data-url-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/url/segments-from-data-url-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Tom Sepez
6 years, 9 months ago (2014-03-03 23:50:40 UTC) #1
Tom Sepez
On 2014/03/03 23:50:40, Tom Sepez wrote: Sorry about the mess. @cbiesinger, please take a look.
6 years, 9 months ago (2014-03-03 23:51:52 UTC) #2
cbiesinger
lgtm On 2014/03/03 23:51:52, Tom Sepez wrote: > On 2014/03/03 23:50:40, Tom Sepez wrote: > ...
6 years, 9 months ago (2014-03-04 00:59:00 UTC) #3
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 9 months ago (2014-03-04 18:20:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/184223007/40001
6 years, 9 months ago (2014-03-04 18:21:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/184223007/40001
6 years, 9 months ago (2014-03-05 20:54:19 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 23:41:53 UTC) #7
Message was sent while issue was closed.
Change committed as 168549

Powered by Google App Engine
This is Rietveld 408576698