Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java

Issue 1842223003: Remove outdated devices from Android device chooser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit test for ItemChooserDialog Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.app.Dialog; 7 import android.app.Dialog;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.DialogInterface; 9 import android.content.DialogInterface;
10 import android.graphics.Color; 10 import android.graphics.Color;
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 public void setIdleState() { 385 public void setIdleState() {
386 mProgressBar.setVisibility(View.GONE); 386 mProgressBar.setVisibility(View.GONE);
387 setState(State.DISCOVERY_IDLE); 387 setState(State.DISCOVERY_IDLE);
388 } 388 }
389 389
390 /** 390 /**
391 * Sets whether the item is enabled. 391 * Sets whether the item is enabled.
392 * @param id The id of the item to affect. 392 * @param id The id of the item to affect.
393 * @param enabled Whether the item should be enabled or not. 393 * @param enabled Whether the item should be enabled or not.
394 */ 394 */
395 @VisibleForTesting
scheib 2016/04/07 22:05:02 Is this needed for this patch?
perja 2016/04/08 07:47:35 I'm not 100% sure about this one. Seems that only
perja 2016/06/24 14:15:28 I have reverted the @VisibleForTesting line now.
395 public void setEnabled(String id, boolean enabled) { 396 public void setEnabled(String id, boolean enabled) {
396 mItemAdapter.setEnabled(id, enabled); 397 mItemAdapter.setEnabled(id, enabled);
397 } 398 }
398 399
399 /** 400 /**
400 * Clear all items from the dialog. 401 * Clear all items from the dialog.
401 */ 402 */
402 public void clear() { 403 public void clear() {
403 mItemAdapter.clear(); 404 mItemAdapter.clear();
404 setState(State.STARTING); 405 setState(State.STARTING);
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 } 443 }
443 444
444 /** 445 /**
445 * Returns the ItemAdapter associated with this class. For use with tests on ly. 446 * Returns the ItemAdapter associated with this class. For use with tests on ly.
446 */ 447 */
447 @VisibleForTesting 448 @VisibleForTesting
448 public ItemAdapter getItemAdapterForTesting() { 449 public ItemAdapter getItemAdapterForTesting() {
449 return mItemAdapter; 450 return mItemAdapter;
450 } 451 }
451 } 452 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698