Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/cpu-profiler-inl.h

Issue 18422003: Correctly report callstack when current function is FunctionCall builtin (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/cpu-profiler.cc ('k') | src/profile-generator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 void CodeMoveEventRecord::UpdateCodeMap(CodeMap* code_map) { 49 void CodeMoveEventRecord::UpdateCodeMap(CodeMap* code_map) {
50 code_map->MoveCode(from, to); 50 code_map->MoveCode(from, to);
51 } 51 }
52 52
53 53
54 void SharedFunctionInfoMoveEventRecord::UpdateCodeMap(CodeMap* code_map) { 54 void SharedFunctionInfoMoveEventRecord::UpdateCodeMap(CodeMap* code_map) {
55 code_map->MoveCode(from, to); 55 code_map->MoveCode(from, to);
56 } 56 }
57 57
58 58
59 void ReportBuiltinEventRecord::UpdateCodeMap(CodeMap* code_map) {
60 CodeEntry* entry = code_map->FindEntry(start);
61 if (!entry) {
62 // Code objects for builtins should already have been added to the map but
63 // some of them have been filtered out by CpuProfiler.
64 return;
65 }
66 entry->SetBuiltinId(builtin_id);
67 }
68
69
59 TickSample* ProfilerEventsProcessor::TickSampleEvent() { 70 TickSample* ProfilerEventsProcessor::TickSampleEvent() {
60 generator_->Tick(); 71 generator_->Tick();
61 TickSampleEventRecord* evt = 72 TickSampleEventRecord* evt =
62 new(ticks_buffer_.Enqueue()) TickSampleEventRecord(enqueue_order_); 73 new(ticks_buffer_.Enqueue()) TickSampleEventRecord(enqueue_order_);
63 return &evt->sample; 74 return &evt->sample;
64 } 75 }
65 76
66 77
67 } } // namespace v8::internal 78 } } // namespace v8::internal
68 79
69 #endif // V8_CPU_PROFILER_INL_H_ 80 #endif // V8_CPU_PROFILER_INL_H_
OLDNEW
« no previous file with comments | « src/cpu-profiler.cc ('k') | src/profile-generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698