Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 18422003: Correctly report callstack when current function is FunctionCall builtin (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow, loislo
CC:
v8-dev
Visibility:
Public.

Description

Correctly report callstack when current function is FunctionCall builtin When current function is FunctionCall builtin we have no reliable way to determine its caller function (in many cases the top of the sampled stack contains address of the caller but sometimes it does not). Instead of dropping the sample or its two top frames we simply mark the caller frame as '(unresolved function)'. It seems like a better approach that dropping whole sample as knowing the top function and the rest of the stack the user should be able to figure out what the caller was. This change adds builtin id to CodeEntry objects. It will be used later to add similar top frame analysis for FunctionApply and probably other builtins. BUG=None TBR=loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15436

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -25 lines) Patch
M src/cpu-profiler.h View 3 chunks +12 lines, -1 line 0 comments Download
M src/cpu-profiler.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/cpu-profiler-inl.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/profile-generator.h View 4 chunks +9 lines, -1 line 0 comments Download
M src/profile-generator.cc View 4 chunks +41 lines, -23 lines 0 comments Download
M src/profile-generator-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
This is exactly same change as r15426 that was reverted due to UNREACHABLE assertion failure. ...
7 years, 5 months ago (2013-07-02 07:48:08 UTC) #1
loislo
lgtm
7 years, 5 months ago (2013-07-02 07:48:55 UTC) #2
yurys
7 years, 5 months ago (2013-07-02 07:51:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15436 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698