Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1842193002: Update SkOffsetImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update to ToT #

Patch Set 3 : Clean up #

Total comments: 8

Patch Set 4 : Address code review issues #

Patch Set 5 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -123 lines) Patch
M bench/BlurImageFilterBench.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/filterfastbounds.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 2 3 3 chunks +52 lines, -29 lines 0 comments Download
M gm/imagefilterscropped.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersstroked.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/lighting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/localmatriximagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/offsetimagefilter.cpp View 1 2 3 5 chunks +14 lines, -17 lines 0 comments Download
M gm/testimagefilters.cpp View 1 3 chunks +30 lines, -22 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 1 2 3 4 9 chunks +30 lines, -19 lines 0 comments Download
M include/effects/SkOffsetImageFilter.h View 1 2 3 3 chunks +14 lines, -5 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 1 chunk +4 lines, -3 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 7 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
robertphillips
4 years, 8 months ago (2016-03-30 20:56:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842193002/40001
4 years, 8 months ago (2016-03-30 20:56:47 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 21:14:17 UTC) #8
f(malita)
lgtm https://codereview.chromium.org/1842193002/diff/40001/gm/imagefilterscropexpand.cpp File gm/imagefilterscropexpand.cpp (right): https://codereview.chromium.org/1842193002/diff/40001/gm/imagefilterscropexpand.cpp#newcode185 gm/imagefilterscropexpand.cpp:185: paint.setImageFilter(filter); nit: move filter https://codereview.chromium.org/1842193002/diff/40001/gm/offsetimagefilter.cpp File gm/offsetimagefilter.cpp (right): ...
4 years, 8 months ago (2016-03-31 13:39:02 UTC) #9
robertphillips
https://codereview.chromium.org/1842193002/diff/40001/gm/imagefilterscropexpand.cpp File gm/imagefilterscropexpand.cpp (right): https://codereview.chromium.org/1842193002/diff/40001/gm/imagefilterscropexpand.cpp#newcode185 gm/imagefilterscropexpand.cpp:185: paint.setImageFilter(filter); On 2016/03/31 13:39:01, f(malita) wrote: > nit: move ...
4 years, 8 months ago (2016-03-31 14:56:15 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842193002/60001
4 years, 8 months ago (2016-03-31 15:28:05 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/7515)
4 years, 8 months ago (2016-03-31 15:29:16 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842193002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842193002/80001
4 years, 8 months ago (2016-03-31 15:46:41 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 16:00:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842193002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842193002/80001
4 years, 8 months ago (2016-03-31 16:04:48 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 16:05:53 UTC) #23
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/51a315eff9b86bd60e7884240c4efc199129d37a

Powered by Google App Engine
This is Rietveld 408576698