Use standard TypeImpl classes during linking.

Use standard TypeImpl classes during linking.

The `...TypeForLink` classes weren't contributing any useful
functionality, and removing them will make it easier to re-use code from
the rest of the analyzer.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c8fb5078d0c0f1e0e7ac22960a0f2aff218afaf1

[Paul Berry, 2016-03-30 19:38:01]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-03-30 19:54:15]

LGTM

https://codereview.chromium.org/1842183002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/link.dart (right):

https://codereview.chromium.org/1842183002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/link.dart:294: return _type ??= new
InterfaceTypeImpl.elementWithNameAndArgs(
Maybe we should use explicit if != null to avoid creating type arguments every
time.

[Paul Berry, 2016-03-30 19:59:53]

https://codereview.chromium.org/1842183002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/link.dart (right):

https://codereview.chromium.org/1842183002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/link.dart:294: return _type ??= new
InterfaceTypeImpl.elementWithNameAndArgs(
On 2016/03/30 19:54:15, scheglov wrote:
> Maybe we should use explicit if != null to avoid creating type arguments every
> time.

Whoops, you're right.  Thanks for catching this.

Done.

[Paul Berry, 2016-03-30 20:02:02]

Description was changed from

==========
Use standard TypeImpl classes during linking.

The `...TypeForLink` classes weren't contributing any useful
functionality, and removing them will make it easier to re-use code from
the rest of the analyzer.
==========

to

==========
Use standard TypeImpl classes during linking.

The `...TypeForLink` classes weren't contributing any useful
functionality, and removing them will make it easier to re-use code from
the rest of the analyzer.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c8fb5078d0c0f1e0e7ac22960a0f2aff218afaf1
==========

[Paul Berry, 2016-03-30 20:02:04]

Committed patchset #1 (id:1) manually as
c8fb5078d0c0f1e0e7ac22960a0f2aff218afaf1 (presubmit successful).