Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1842163002: SkPDF: SkTypeface::openStream could return nullptr (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: SkTypeface::openStream could return nullptr Speculative fix for hard-to-reproduce bug. BUG=163892 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842163002 Committed: https://skia.googlesource.com/skia/+/3243143f25f4ccba632847574cf8e1a8ee0fe0f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M src/pdf/SkPDFFont.cpp View 5 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hal.canary
Please take a look.
4 years, 8 months ago (2016-03-30 18:49:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842163002/1
4 years, 8 months ago (2016-03-30 19:31:21 UTC) #5
bungeman-skia
lgtm
4 years, 8 months ago (2016-03-30 19:34:02 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 19:41:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842163002/1
4 years, 8 months ago (2016-03-30 19:58:20 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 19:59:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3243143f25f4ccba632847574cf8e1a8ee0fe0f2

Powered by Google App Engine
This is Rietveld 408576698