Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5179)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 1842133002: relnote: Retransmit initially encrypted packets when a reject is (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_flags.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 38bb4c4f5589c953fc7c456cf78cf9a016b72143..e59d19f3ba065a949866f490555037b05a850fc3 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -449,13 +449,12 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
// being discarded, based on connection stats.
// Calls server_thread_ Pause() and Resume(), which may only be called once
// per test.
- void VerifyCleanConnection(bool /*had_packet_loss*/) {
+ void VerifyCleanConnection(bool had_packet_loss) {
QuicConnectionStats client_stats =
client_->client()->session()->connection()->GetStats();
- // TODO(ianswett): Re-enable this check once b/19572432 is fixed.
- // if (!had_packet_loss) {
- // EXPECT_EQ(0u, client_stats.packets_lost);
- // }
+ if (FLAGS_quic_reply_to_rej && !had_packet_loss) {
+ EXPECT_EQ(0u, client_stats.packets_lost);
+ }
EXPECT_EQ(0u, client_stats.packets_discarded);
// When doing 0-RTT with stateless rejects, the encrypted requests cause
// a retranmission of the SREJ packets which are dropped by the client.
@@ -478,10 +477,9 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
ASSERT_EQ(1u, dispatcher->session_map().size());
QuicSession* session = dispatcher->session_map().begin()->second;
QuicConnectionStats server_stats = session->connection()->GetStats();
- // TODO(ianswett): Re-enable this check once b/19572432 is fixed.
- // if (!had_packet_loss) {
- // EXPECT_EQ(0u, server_stats.packets_lost);
- // }
+ if (FLAGS_quic_reply_to_rej && !had_packet_loss) {
+ EXPECT_EQ(0u, server_stats.packets_lost);
+ }
EXPECT_EQ(0u, server_stats.packets_discarded);
// TODO(ianswett): Restore the check for packets_dropped equals 0.
// The expect for packets received is equal to packets processed fails
« no previous file with comments | « net/quic/quic_flags.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698