Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 184213006: Add icon to the streamlined hosted app creation dialog. (Closed)

Created:
6 years, 9 months ago by calamity
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git@ares_hide_search_box
Visibility:
Public.

Description

Add icon to the streamlined hosted app creation dialog. This CL adds an ImageView that displays the icon to the BookmarkAppBubbleView. It also moves the "Open as tab" checkbox to the same line as the buttons to save on vertical space which was consumed by the square icon. BUG=318607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -14 lines) Patch
M chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h View 4 chunks +22 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc View 8 chunks +38 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
calamity
6 years, 9 months ago (2014-03-06 07:34:32 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-06 16:42:20 UTC) #2
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 9 months ago (2014-03-07 03:34:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/184213006/1
6 years, 9 months ago (2014-03-07 03:36:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 05:47:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 05:47:58 UTC) #6
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 9 months ago (2014-03-07 06:11:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/184213006/1
6 years, 9 months ago (2014-03-07 06:15:57 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 06:53:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 06:53:14 UTC) #10
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 9 months ago (2014-03-09 01:37:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/184213006/1
6 years, 9 months ago (2014-03-09 01:37:36 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 02:49:43 UTC) #13
Message was sent while issue was closed.
Change committed as 255810

Powered by Google App Engine
This is Rietveld 408576698