Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 184213004: Fix fast/repaint/block-layout-inline-children-replaced.html (Closed)

Created:
6 years, 9 months ago by Julien - ping for review
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr
Visibility:
Public.

Description

Fix fast/repaint/block-layout-inline-children-replaced.html The test was loading an image but didn't wait for the image to fully load to get all the invalidations generated. The extra 2 invalidations come from the image (92 x 100) and its container (402 x 100). The fix involves allowing our invalidation harness to run asynchronously. While touching the code, removed some unneeded window-prefix. BUG=313447 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168491

Patch Set 1 #

Patch Set 2 : Rebaselined change #

Patch Set 3 : Re-added the post-test hook as it is needed by svg/dynamic-updates/ tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -25 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/block-layout-inline-children-replaced.html View 1 chunk +6 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/resources/text-based-repaint.js View 1 2 1 chunk +39 lines, -23 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/block-layout-inline-children-replaced-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Julien - ping for review
6 years, 9 months ago (2014-03-04 02:53:04 UTC) #1
eseidel
James has been in this code more recently than I.
6 years, 9 months ago (2014-03-04 08:59:30 UTC) #2
jamesr
lgtm most tests have their resources in the document at DOMContentLoaded time and just call ...
6 years, 9 months ago (2014-03-04 20:22:07 UTC) #3
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-04 21:15:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/184213004/20001
6 years, 9 months ago (2014-03-04 21:16:37 UTC) #5
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 9 months ago (2014-03-04 22:40:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/184213004/40001
6 years, 9 months ago (2014-03-04 22:40:12 UTC) #7
Julien - ping for review
6 years, 9 months ago (2014-03-05 15:52:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r168491 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698