[win] Set the profile path when enabling the app launcher.

chrome/browser/ui/app_list/app_list_service.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_H_
 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 18 matching lines @@
   // Get the AppListService for the current platform and desktop type.
   static AppListService* Get();
 
   // Call Init for all AppListService instances on this platform.
   static void InitAll(Profile* initial_profile);
 
   static void RegisterPrefs(PrefRegistrySimple* registry);
 
   virtual base::FilePath GetProfilePath(
       const base::FilePath& user_data_dir) = 0;
+  virtual void SetProfilePath(const base::FilePath& profile_path) = 0;
 
   static void RecordShowTimings(const CommandLine& command_line);
 
   // Show the app list.
   virtual void ShowAppList(Profile* requested_profile) = 0;
 
   // Dismiss the app list.
   virtual void DismissAppList() = 0;
 
-  // TODO(koz): Merge this into ShowAppList().

[benwells, 2013/07/12 01:41:48]

I think this renaming is a cleanup and not necessary to fix the profile bug. Why
has the TODO gone too?

[tapted, 2013/07/12 04:58:27]

The 2-3 parts of this function were (a) set the local_pref (b) maybe load the
profile asynchronously, and (c) show the app list.

(a) is now SetProfilePath, which is now also needed by EnableAppList, so we can
set a profile without showing it the launcher.

(b)-(c) are ShowForSavedProfile

The (a) part is merged into ShowAppList, but it doesn't make sense for (b) and
(c) to go there, since that path is only needed when there's a chance the
Profile is not leaded, which is never the case for ShowAppList.

-  virtual void SetAppListProfile(const base::FilePath& profile_file_path) = 0;
-
   // Show the app list for the profile configured in the user data dir for the
   // current browser process.
   virtual void ShowForSavedProfile() = 0;
 
   // Get the profile the app list is currently showing.
   virtual Profile* GetCurrentAppListProfile() = 0;
 
   // Returns true if the app list is visible.
   virtual bool IsAppListVisible() const = 0;
 
   // Enable the app list. What this does specifically will depend on the host
   // operating system and shell.
-  virtual void EnableAppList() = 0;
+  virtual void EnableAppList(Profile* initial_profile) = 0;
 
   // Get the window the app list is in, or NULL if the app list isn't visible.
   virtual gfx::NativeWindow GetAppListWindow() = 0;
 
   // Exposed to allow testing of the controller delegate.
   virtual AppListControllerDelegate* CreateControllerDelegate() = 0;
 
  protected:
   AppListService() {}
   virtual ~AppListService() {}
 
   // Do any once off initialization needed for the app list.
   virtual void Init(Profile* initial_profile) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(AppListService);
 };
 
 #endif  // CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_H_