Issue 18421006: Resolve em units against the specified font size in SVG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18421006: Resolve em units against the specified font size in SVG (Closed)

Created:
7 years, 5 months ago by pdr.

Modified:
7 years, 5 months ago

Reviewers:
Stephen Chennney, fmalita_google_do_not_use

CC:
blink-reviews, pdr, f(malita), dglazkov+blink, eae+blinkwatch, Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Resolve em units against the specified font size in SVG SVG doesn't scale zoomed font units so zooming should not affect font sizes. This patch fixes a bug where em lengths were resolved against the style's font size (with zoom) instead of the specified font size (without zoom). BUG=245996 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154004

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -2 lines)			Patch
A	LayoutTests/svg/zoom/text/zoom-em-units.html	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/zoom/text/zoom-em-units-expected.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGLengthContext.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/18421006/1

7 years, 5 months ago (2013-07-11 11:50:46 UTC) #3

Message was sent while issue was closed.

Change committed as 154004

Expand Messages | Collapse Messages