Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1842093003: S390: Implement RotRight64 (Closed)

Created:
4 years, 8 months ago by JoranSiu
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Implement RotRight64 Properly implement Rotate Right sequence for S390, to use the 64-bit RLLG instruction. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Committed: https://crrev.com/555c46113f39e1f5fd966276d03809bfc9400847 Cr-Commit-Position: refs/heads/master@{#35142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842093003/1
4 years, 8 months ago (2016-03-30 19:53:41 UTC) #2
JoranSiu
PTAL
4 years, 8 months ago (2016-03-30 19:53:42 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 20:14:40 UTC) #5
john.yan
lgtm
4 years, 8 months ago (2016-03-30 20:16:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842093003/1
4 years, 8 months ago (2016-03-30 20:32:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 20:34:59 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:36:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/555c46113f39e1f5fd966276d03809bfc9400847
Cr-Commit-Position: refs/heads/master@{#35142}

Powered by Google App Engine
This is Rietveld 408576698