Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1842043002: gn format the BUILD.gn file (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

gn format the BUILD.gn file Also protect builtin files with # NOSORT as the order is important here. BUG= R=machenbach@chromium.org LOG=n Committed: https://crrev.com/799eea1714ee7ddbbcee3687ae4a75b05a45e809 Cr-Commit-Position: refs/heads/master@{#35150}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -101 lines) Patch
M BUILD.gn View 48 chunks +116 lines, -101 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-03-30 14:40:38 UTC) #1
Michael Achenbach
lgtm
4 years, 8 months ago (2016-03-31 07:17:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842043002/1
4 years, 8 months ago (2016-03-31 07:28:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 07:30:23 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/799eea1714ee7ddbbcee3687ae4a75b05a45e809 Cr-Commit-Position: refs/heads/master@{#35150}
4 years, 8 months ago (2016-03-31 07:33:10 UTC) #7
Yang
https://codereview.chromium.org/1842043002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1842043002/diff/1/BUILD.gn#newcode477 BUILD.gn:477: "src/objects-inl.h", Reordering arguments causes this script to fail.
4 years, 8 months ago (2016-03-31 10:49:13 UTC) #9
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-03-31 10:51:39 UTC) #10
Message was sent while issue was closed.
On 2016/03/31 at 10:49:13, yangguo wrote:
> https://codereview.chromium.org/1842043002/diff/1/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/1842043002/diff/1/BUILD.gn#newcode477
> BUILD.gn:477: "src/objects-inl.h",
> Reordering arguments causes this script to fail.

https://codereview.chromium.org/1845473007

Powered by Google App Engine
This is Rietveld 408576698