Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 1842013003: Replace FXJSE_DOUBLE with double (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace FXJSE_DOUBLE with double FXJSE_DOUBLE was just defined as double. Replace with actual type to make things clearer. BUG=pdfium:81 Committed: https://pdfium.googlesource.com/pdfium/+/04fd27b3742ace6e76d70e19ca7a4ff178c4cdc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M xfa/fxjse/include/fxjse.h View 3 chunks +3 lines, -4 lines 0 comments Download
M xfa/fxjse/value.h View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxjse/value.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-03-30 19:25:45 UTC) #3
Tom Sepez
lgtm
4 years, 8 months ago (2016-03-30 19:56:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842013003/1
4 years, 8 months ago (2016-03-30 19:58:48 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 19:59:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/04fd27b3742ace6e76d70e19ca7a4ff178c4...

Powered by Google App Engine
This is Rietveld 408576698