Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1842013002: [wasm] Refactoring pair-shift code in the instruction selector of arm and ia32. (Closed)

Created:
4 years, 8 months ago by ahaas
Modified:
4 years, 8 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Refactoring pair-shift code in the instruction selector of arm and ia32. R=titzer@chromium.org Committed: https://crrev.com/f954934d6237998f26b6784b22b1e6f02b8b430b Cr-Commit-Position: refs/heads/master@{#35140}

Patch Set 1 #

Patch Set 2 : Restored the original arm code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -39 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +10 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 8 months ago (2016-03-30 12:47:25 UTC) #1
titzer
lgtm
4 years, 8 months ago (2016-03-30 12:57:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842013002/20001
4 years, 8 months ago (2016-03-30 14:22:45 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 14:24:42 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 14:26:28 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f954934d6237998f26b6784b22b1e6f02b8b430b
Cr-Commit-Position: refs/heads/master@{#35140}

Powered by Google App Engine
This is Rietveld 408576698