Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Issue 18420019: Change the type of system root nodes in heap snapshot to kSynthetic (Closed)

Created:
7 years, 5 months ago by alph
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change the type of system root nodes in heap snapshot to kSynthetic R=mstarzinger@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/heap-snapshot-generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alph
Folks, could you please take a look.
7 years, 5 months ago (2013-07-04 15:51:56 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
7 years, 5 months ago (2013-07-04 16:16:11 UTC) #2
yurys
lgtm
7 years, 5 months ago (2013-07-04 16:30:47 UTC) #3
alph
7 years, 5 months ago (2013-07-04 16:32:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15492 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698