Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1841933003:
Fixing readibility by using base::DoNothing() in base::Bind()s. (Closed)
|
Created:
4 years, 8 months ago by maksims (do not use this acc) Modified:
4 years, 8 months ago CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUsing base::DoNothing() in base::Bind()s instead of
DisableAecDumpOnFileThread() for better readability.
BUG=598498
Committed: https://crrev.com/1d1d8643007866c852a5482653c9dfe254e15f2a
Cr-Commit-Position: refs/heads/master@{#384196}
Patch Set 1 #
Messages
Total messages: 26 (15 generated)
maksim.sisov@intel.com changed reviewers: + grunell@chromium.org, mcasas@chromium.org
Please take a look
Thanks! Please update the title to make more sense - it's cut off now. lgtm.
No need for mcasas@ to review, but you need an owner.
Description was changed from ========== Using base::DoNothing() in base::Bind()s instead of DisableAecDumpOnFileThread() for better readability. BUG=598498 ========== to ========== Using base::DoNothing() in base::Bind()s instead of DisableAecDumpOnFileThread() for better readability. BUG=598498 ==========
maksim.sisov@intel.com changed reviewers: - mcasas@chromium.org
The CQ bit was checked by maksim.sisov@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841933003/1
The CQ bit was unchecked by maksim.sisov@intel.com
maksim.sisov@intel.com changed reviewers: + ananta@chromium.org, sadrul@chromium.org
The CQ bit was checked by maksim.sisov@intel.com
The CQ bit was unchecked by maksim.sisov@intel.com
The CQ bit was checked by maksim.sisov@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841933003/1
The CQ bit was unchecked by maksim.sisov@intel.com
The CQ bit was checked by maksim.sisov@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841933003/1
The CQ bit was unchecked by maksim.sisov@intel.com
stamp lgtm
The CQ bit was checked by maksim.sisov@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841933003/1
Message was sent while issue was closed.
Description was changed from ========== Using base::DoNothing() in base::Bind()s instead of DisableAecDumpOnFileThread() for better readability. BUG=598498 ========== to ========== Using base::DoNothing() in base::Bind()s instead of DisableAecDumpOnFileThread() for better readability. BUG=598498 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Using base::DoNothing() in base::Bind()s instead of DisableAecDumpOnFileThread() for better readability. BUG=598498 ========== to ========== Using base::DoNothing() in base::Bind()s instead of DisableAecDumpOnFileThread() for better readability. BUG=598498 Committed: https://crrev.com/1d1d8643007866c852a5482653c9dfe254e15f2a Cr-Commit-Position: refs/heads/master@{#384196} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1d1d8643007866c852a5482653c9dfe254e15f2a Cr-Commit-Position: refs/heads/master@{#384196} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
