Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1841903002: Redirect to offline copy on other possible internet connection failures (Closed)

Created:
4 years, 8 months ago by jianli
Modified:
4 years, 8 months ago
Reviewers:
fgorski
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Redirect to offline copy on other possible internet connection failures BUG=597405 Committed: https://crrev.com/71305613fab6397a9c65f7af7f6154039ebe5df7 Cr-Commit-Position: refs/heads/master@{#384090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/android/offline_pages/offline_page_tab_helper.cc View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jianli
4 years, 8 months ago (2016-03-30 01:18:40 UTC) #2
fgorski
lgtm
4 years, 8 months ago (2016-03-30 01:45:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841903002/1
4 years, 8 months ago (2016-03-30 20:56:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 21:03:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 21:04:35 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/71305613fab6397a9c65f7af7f6154039ebe5df7
Cr-Commit-Position: refs/heads/master@{#384090}

Powered by Google App Engine
This is Rietveld 408576698