Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: content/browser/devtools/protocol/service_worker_handler.h

Issue 1841863003: DevTools: move the force update SW on reload checkbox to the Resources / Service Workers view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fixed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/service_worker_handler.h
diff --git a/content/browser/devtools/protocol/service_worker_handler.h b/content/browser/devtools/protocol/service_worker_handler.h
index b16a41b05176e7b9056fb426ff48fad316b6dfeb..02dcd8c43f5309ba917073e10d8afb94ec3b90be 100644
--- a/content/browser/devtools/protocol/service_worker_handler.h
+++ b/content/browser/devtools/protocol/service_worker_handler.h
@@ -57,9 +57,7 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
Response StopWorker(const std::string& version_id);
Response UpdateRegistration(const std::string& scope_url);
Response InspectWorker(const std::string& version_id);
- Response SetDebugOnStart(bool debug_on_start);
- Response SetForceUpdateOnPageLoad(const std::string& registration_id,
- bool force_update_on_page_load);
+ Response SetForceUpdateOnPageLoad(bool force_update_on_page_load);
Response DeliverPushMessage(const std::string& origin,
const std::string& registration_id,
const std::string& data);
@@ -71,7 +69,6 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
void WorkerCreated(ServiceWorkerDevToolsAgentHost* host) override;
void WorkerReadyForInspection(ServiceWorkerDevToolsAgentHost* host) override;
void WorkerDestroyed(ServiceWorkerDevToolsAgentHost* host) override;
- void DebugOnStartUpdated(bool debug_on_start) override;
private:
// DevToolsAgentHostClient overrides.
@@ -101,7 +98,6 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
std::set<GURL> urls_;
scoped_refptr<ServiceWorkerContextWatcher> context_watcher_;
RenderFrameHostImpl* render_frame_host_;
- std::set<int> force_update_enabled_registrations_;
base::WeakPtrFactory<ServiceWorkerHandler> weak_factory_;
« no previous file with comments | « no previous file | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698