DevTools: move the force update SW on reload checkbox to the Resources / Service Workers view.

third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 26 matching lines @@
 {
     WebInspector.SDKObject.call(this, target);
     target.registerServiceWorkerDispatcher(new WebInspector.ServiceWorkerDispatcher(this));
     this._lastAnonymousTargetId = 0;
     this._agent = target.serviceWorkerAgent();
     /** @type {!Map.<string, !WebInspector.ServiceWorker>} */
     this._workers = new Map();
     /** @type {!Map.<string, !WebInspector.ServiceWorkerRegistration>} */
     this._registrations = new Map();
     this.enable();
+    this._forceUpdateSetting = WebInspector.settings.moduleSetting("serviceWorkerUpdateOnReload");

[dgozman, 2016/03/30 21:09:54]

Just createSetting(), don't declare it in module.json.

[pfeldman, 2016/03/31 05:02:31]

Done.

+    if (this._forceUpdateSetting.get())
+        this._forceUpdateSettingChanged();
+    this._forceUpdateSetting.addChangeListener(this._forceUpdateSettingChanged, this);
 }
 
 WebInspector.ServiceWorkerManager.Events = {
     WorkersUpdated: "WorkersUpdated",
     RegistrationUpdated: "RegistrationUpdated",
     RegistrationDeleted: "RegistrationDeleted",
     DebugOnStartUpdated: "DebugOnStartUpdated"
 }

[horo, 2016/03/30 05:17:35]

If "force update on reload" flag is global, ServiceWorkerManager should send
"force update on reload updated" event to update the checkoboxes in multiple
DevTools windows.

[pfeldman, 2016/03/30 17:11:44]

I don't think so. This is a user setting, stored in our preferences. It should
not be controlled externally. If we want to synchronize its value, we should do
that by the front-end means. This adds quite a bit of complexity though, so I
would leave it as is and let the latter win. We are talking about edge case
here.

[horo, 2016/03/31 02:39:45]

OK.
Then please remove "DebugOnStartUpdated" from here.

[pfeldman, 2016/03/31 05:02:31]

Done.

 
 WebInspector.ServiceWorkerManager.prototype = {
     enable: function()
     {
         if (this._enabled)
             return;
         this._enabled = true;
 
         this._agent.enable();
         WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.MainFrameNavigated, this._mainFrameNavigated, this);
@@ skipping 39 matching lines @@
 
     /**
      * @param {boolean} flag
      */
     setDebugOnStart: function(flag)
     {
         this._agent.setDebugOnStart(flag);
     },
 
     /**
-     * @param {string} registrationId
-     * @param {boolean} flag
-     */
-    setForceUpdateOnPageLoad: function(registrationId, flag)
-    {
-        this._agent.setForceUpdateOnPageLoad(registrationId, flag);
-    },
-
-    /**
      * @return {!Map.<string, !WebInspector.ServiceWorkerRegistration>}
      */
     registrations: function()
     {
         return this._registrations;
     },
 
     /**
      * @param {string} versionId
      * @return {?WebInspector.ServiceWorkerVersion}
@@ skipping 222 matching lines @@
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _mainFrameNavigated: function(event)
     {
         // Attach to the new worker set.
     },
 
+    /**
+     * @return {!WebInspector.Setting}
+     */
+    forceUpdateOnReloadSetting: function()
+    {
+        return this._forceUpdateSetting;
+    },
+
+    _forceUpdateSettingChanged: function()
+    {
+        this._agent.setForceUpdateOnPageLoad(this._forceUpdateSetting.get());
+    },
+
     __proto__: WebInspector.SDKObject.prototype
 }
 
 /**
  * @constructor
  * @param {!WebInspector.ServiceWorkerManager} manager
  * @param {string} workerId
  * @param {string} url
  * @param {string} versionId
  */
@@ skipping 449 matching lines @@
     },
 
     /**
      * @return {boolean}
      */
     _shouldBeRemoved: function()
     {
         return this._isRedundant() && (!this._hasErrorLog() || this._deleting);
     }
 }