Index: build/secondary/tools/grit/grit_rule.gni |
diff --git a/build/secondary/tools/grit/grit_rule.gni b/build/secondary/tools/grit/grit_rule.gni |
index 35bbed32734815ec67ecad23ccb411f5cd661a49..5242adb614e37c950b690c77aaea4b85dd14d5b3 100644 |
--- a/build/secondary/tools/grit/grit_rule.gni |
+++ b/build/secondary/tools/grit/grit_rule.gni |
@@ -107,15 +107,6 @@ if (is_chrome_branded) { |
] |
} |
-if (is_chromeos) { |
- grit_defines += [ |
- "-D", |
- "chromeos", |
- "-D", |
- "scale_factors=2x", |
- ] |
-} |
- |
if (is_desktop_linux) { |
grit_defines += [ |
"-D", |
@@ -123,27 +114,6 @@ if (is_desktop_linux) { |
] |
} |
-if (toolkit_views) { |
- grit_defines += [ |
- "-D", |
- "toolkit_views", |
- ] |
-} |
- |
-if (use_aura) { |
- grit_defines += [ |
- "-D", |
- "use_aura", |
- ] |
-} |
- |
-if (use_ash) { |
- grit_defines += [ |
- "-D", |
- "use_ash", |
- ] |
-} |
- |
if (use_nss_certs) { |
grit_defines += [ |
"-D", |
@@ -158,20 +128,6 @@ if (use_ozone) { |
] |
} |
-if (enable_image_loader_extension) { |
- grit_defines += [ |
- "-D", |
- "image_loader_extension", |
- ] |
-} |
- |
-if (enable_remoting) { |
- grit_defines += [ |
- "-D", |
- "remoting", |
- ] |
-} |
- |
if (is_android) { |
grit_defines += [ |
"-t", |
@@ -199,106 +155,6 @@ if (is_ios) { |
] |
} |
-if (enable_extensions) { |
- grit_defines += [ |
- "-D", |
- "enable_extensions", |
- ] |
-} |
-if (enable_media_router) { |
- grit_defines += [ |
- "-D", |
- "enable_media_router", |
- ] |
-} |
-if (enable_plugins) { |
- grit_defines += [ |
- "-D", |
- "enable_plugins", |
- ] |
-} |
-if (enable_basic_printing || enable_print_preview) { |
- grit_defines += [ |
- "-D", |
- "enable_printing", |
- ] |
- if (enable_print_preview) { |
- grit_defines += [ |
- "-D", |
- "enable_print_preview", |
- ] |
- } |
-} |
-if (enable_themes) { |
- grit_defines += [ |
- "-D", |
- "enable_themes", |
- ] |
-} |
-if (enable_app_list) { |
- grit_defines += [ |
- "-D", |
- "enable_app_list", |
- ] |
-} |
-if (enable_settings_app) { |
- grit_defines += [ |
- "-D", |
- "enable_settings_app", |
- ] |
-} |
-if (enable_google_now) { |
- grit_defines += [ |
- "-D", |
- "enable_google_now", |
- ] |
-} |
- |
-# Note: use_concatenated_impulse_responses is omitted. It is never used and |
-# should probably be removed from GYP build. |
-if (enable_webrtc) { |
- grit_defines += [ |
- "-D", |
- "enable_webrtc", |
- ] |
-} |
-if (enable_hangout_services_extension) { |
- grit_defines += [ |
- "-D", |
- "enable_hangout_services_extension", |
- ] |
-} |
-if (enable_task_manager) { |
- grit_defines += [ |
- "-D", |
- "enable_task_manager", |
- ] |
-} |
-if (enable_notifications) { |
- grit_defines += [ |
- "-D", |
- "enable_notifications", |
- ] |
-} |
-if (enable_wifi_bootstrapping) { |
- grit_defines += [ |
- "-D", |
- "enable_wifi_bootstrapping", |
- ] |
-} |
-if (enable_service_discovery) { |
- grit_defines += [ |
- "-D", |
- "enable_service_discovery", |
- ] |
-} |
-if (mac_views_browser) { |
- grit_defines += [ |
- "-D", |
- "mac_views_browser", |
- ] |
-} |
- |
grit_resource_id_file = "//tools/gritsettings/resource_ids" |
grit_info_script = "//tools/grit/grit_info.py" |
@@ -313,7 +169,11 @@ template("grit") { |
} else { |
resource_ids = grit_resource_id_file |
} |
- grit_inputs += [ resource_ids ] # Script depends on ID file. |
+ if (resource_ids != "") { |
+ # The script depends on the ID file. Only add this dependency if the ID |
+ # file is specified. |
+ grit_inputs += [ resource_ids ] |
+ } |
if (defined(invoker.output_dir)) { |
output_dir = invoker.output_dir |
@@ -445,9 +305,11 @@ template("grit") { |
# depend on us. |
sources = grit_outputs |
- # Deps set on the template invocation will go on the grit script running |
- # target rather than this library. |
- deps = [ |
+ # Deps set on the template invocation will go on the action that runs |
+ # grit above rather than this library. This target needs to depend on the |
+ # action publicly so other scripts can take the outputs from the grit |
+ # script as inputs. |
+ public_deps = [ |
":$grit_custom_target", |
] |
public_configs = [ ":$grit_config" ] |