Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: tools/sort-headers.py

Issue 1841863002: Update monet. (Closed) Base URL: https://github.com/domokit/monet.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/run_hooks.py ('k') | tools/sort_sources.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/sort-headers.py
diff --git a/tools/sort-headers.py b/tools/sort-headers.py
new file mode 100755
index 0000000000000000000000000000000000000000..08031b2cfd88dd99de2e6f1e09b5d01858604b95
--- /dev/null
+++ b/tools/sort-headers.py
@@ -0,0 +1,192 @@
+#!/usr/bin/env python
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Given a filename as an argument, sort the #include/#imports in that file.
+
+Shows a diff and prompts for confirmation before doing the deed.
+Works great with tools/git/for-all-touched-files.py.
+"""
+
+import optparse
+import os
+import sys
+
+
+def YesNo(prompt):
+ """Prompts with a yes/no question, returns True if yes."""
+ print prompt,
+ sys.stdout.flush()
+ # http://code.activestate.com/recipes/134892/
+ if sys.platform == 'win32':
+ import msvcrt
+ ch = msvcrt.getch()
+ else:
+ import termios
+ import tty
+ fd = sys.stdin.fileno()
+ old_settings = termios.tcgetattr(fd)
+ ch = 'n'
+ try:
+ tty.setraw(sys.stdin.fileno())
+ ch = sys.stdin.read(1)
+ finally:
+ termios.tcsetattr(fd, termios.TCSADRAIN, old_settings)
+ print ch
+ return ch in ('Y', 'y')
+
+
+def IncludeCompareKey(line):
+ """Sorting comparator key used for comparing two #include lines.
+ Returns the filename without the #include/#import/import prefix.
+ """
+ for prefix in ('#include ', '#import ', 'import '):
+ if line.startswith(prefix):
+ line = line[len(prefix):]
+ break
+
+ # In sky, config.h must always be first to defined HAVE, USE, etc.
+ if line.startswith('"sky/engine/config.h"'):
+ return '0'
+
+ # The win32 api has all sorts of implicit include order dependencies :-/
+ # Give a few headers special sort keys that make sure they appear before all
+ # other headers.
+ if line.startswith('<windows.h>'): # Must be before e.g. shellapi.h
+ return '0'
+ if line.startswith('<atlbase.h>'): # Must be before atlapp.h.
+ return '1' + line
+ if line.startswith('<ole2.h>'): # Must be before e.g. intshcut.h
+ return '1' + line
+ if line.startswith('<unknwn.h>'): # Must be before e.g. intshcut.h
+ return '1' + line
+
+ # C++ system headers should come after C system headers.
+ if line.startswith('<'):
+ if line.find('.h>') != -1:
+ return '2' + line.lower()
+ else:
+ return '3' + line.lower()
+
+ return '4' + line
+
+
+def IsInclude(line):
+ """Returns True if the line is an #include/#import/import line."""
+ return any([line.startswith('#include '), line.startswith('#import '),
+ line.startswith('import ')])
+
+
+def SortHeader(infile, outfile):
+ """Sorts the headers in infile, writing the sorted file to outfile."""
+ for line in infile:
+ if IsInclude(line):
+ headerblock = []
+ while IsInclude(line):
+ infile_ended_on_include_line = False
+ headerblock.append(line)
+ # Ensure we don't die due to trying to read beyond the end of the file.
+ try:
+ line = infile.next()
+ except StopIteration:
+ infile_ended_on_include_line = True
+ break
+ for header in sorted(headerblock, key=IncludeCompareKey):
+ outfile.write(header)
+ if infile_ended_on_include_line:
+ # We already wrote the last line above; exit to ensure it isn't written
+ # again.
+ return
+ # Intentionally fall through, to write the line that caused
+ # the above while loop to exit.
+ outfile.write(line)
+
+
+def FixFileWithConfirmFunction(filename, confirm_function,
+ perform_safety_checks):
+ """Creates a fixed version of the file, invokes |confirm_function|
+ to decide whether to use the new file, and cleans up.
+
+ |confirm_function| takes two parameters, the original filename and
+ the fixed-up filename, and returns True to use the fixed-up file,
+ false to not use it.
+
+ If |perform_safety_checks| is True, then the function checks whether it is
+ unsafe to reorder headers in this file and skips the reorder with a warning
+ message in that case.
+ """
+ if perform_safety_checks and IsUnsafeToReorderHeaders(filename):
+ print ('Not reordering headers in %s as the script thinks that the '
+ 'order of headers in this file is semantically significant.'
+ % (filename))
+ return
+ fixfilename = filename + '.new'
+ infile = open(filename, 'rb')
+ outfile = open(fixfilename, 'wb')
+ SortHeader(infile, outfile)
+ infile.close()
+ outfile.close() # Important so the below diff gets the updated contents.
+
+ try:
+ if confirm_function(filename, fixfilename):
+ if sys.platform == 'win32':
+ os.unlink(filename)
+ os.rename(fixfilename, filename)
+ finally:
+ try:
+ os.remove(fixfilename)
+ except OSError:
+ # If the file isn't there, we don't care.
+ pass
+
+
+def DiffAndConfirm(filename, should_confirm, perform_safety_checks):
+ """Shows a diff of what the tool would change the file named
+ filename to. Shows a confirmation prompt if should_confirm is true.
+ Saves the resulting file if should_confirm is false or the user
+ answers Y to the confirmation prompt.
+ """
+ def ConfirmFunction(filename, fixfilename):
+ diff = os.system('diff -u %s %s' % (filename, fixfilename))
+ if sys.platform != 'win32':
+ diff >>= 8
+ if diff == 0: # Check exit code.
+ print '%s: no change' % filename
+ return False
+
+ return (not should_confirm or YesNo('Use new file (y/N)?'))
+
+ FixFileWithConfirmFunction(filename, ConfirmFunction, perform_safety_checks)
+
+def IsUnsafeToReorderHeaders(filename):
+ # *_message_generator.cc is almost certainly a file that generates IPC
+ # definitions. Changes in include order in these files can result in them not
+ # building correctly.
+ if filename.find("message_generator.cc") != -1:
+ return True
+ return False
+
+def main():
+ parser = optparse.OptionParser(usage='%prog filename1 filename2 ...')
+ parser.add_option('-f', '--force', action='store_false', default=True,
+ dest='should_confirm',
+ help='Turn off confirmation prompt.')
+ parser.add_option('--no_safety_checks',
+ action='store_false', default=True,
+ dest='perform_safety_checks',
+ help='Do not perform the safety checks via which this '
+ 'script refuses to operate on files for which it thinks '
+ 'the include ordering is semantically significant.')
+ opts, filenames = parser.parse_args()
+
+ if len(filenames) < 1:
+ parser.print_help()
+ return 1
+
+ for filename in filenames:
+ DiffAndConfirm(filename, opts.should_confirm, opts.perform_safety_checks)
+
+
+if __name__ == '__main__':
+ sys.exit(main())
« no previous file with comments | « tools/run_hooks.py ('k') | tools/sort_sources.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698