Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: sdch/BUILD.gn

Issue 1841863002: Update monet. (Closed) Base URL: https://github.com/domokit/monet.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/websockets/websocket_stream_cookie_test.cc ('k') | testing/android/appurify_support.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdch/BUILD.gn
diff --git a/sdch/BUILD.gn b/sdch/BUILD.gn
index 3ceeeb47b054c9dd609819bf006889a8e0660bda..c83b7be08bd0a440778c52a79f61683e9c4a1893 100644
--- a/sdch/BUILD.gn
+++ b/sdch/BUILD.gn
@@ -6,6 +6,23 @@ config("sdch_config") {
include_dirs = [ "open-vcdiff/src" ]
}
+# gn orders flags on a target before flags from configs. The default config
+# adds -Wall, and these flags have to be after -Wall -- so they need to come
+# from a config and can't be on the target directly.
+config("sdch_warnings") {
+ cflags = []
+ if (is_linux) {
+ # TODO(mostynb): remove this if open-vcdiff is ever updated for c++11:
+ cflags += [ "-Wno-deprecated-declarations" ]
+ }
+
+ if (is_clang) {
+ # sdch uses the pre-c++11 typedef-as-static_assert hack.
+ # https://code.google.com/p/open-vcdiff/issues/detail?id=44
+ cflags += [ "-Wno-unused-local-typedef" ]
+ }
+}
+
static_library("sdch") {
sources = [
"logging_forward.h",
@@ -49,22 +66,6 @@ static_library("sdch") {
"//third_party/zlib",
]
- # gn orders flags on a target before flags from configs. The default config
- # adds -Wall, and these flags have to be after -Wall -- so they need to come
- # from a config and can't be on the target directly.
- config("sdch_warnings") {
- cflags = []
- if (is_linux) {
- # TODO(mostynb): remove this if open-vcdiff is ever updated for c++11:
- cflags += [ "-Wno-deprecated-declarations" ]
- }
-
- if (is_clang) {
- # sdch uses the pre-c++11 typedef-as-static_assert hack.
- # https://code.google.com/p/open-vcdiff/issues/detail?id=44
- cflags += [ "-Wno-unused-local-typedef" ]
- }
- }
configs += [ ":sdch_warnings" ]
if (is_linux || is_android) {
« no previous file with comments | « net/websockets/websocket_stream_cookie_test.cc ('k') | testing/android/appurify_support.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698