Index: sdch/BUILD.gn |
diff --git a/sdch/BUILD.gn b/sdch/BUILD.gn |
index 3ceeeb47b054c9dd609819bf006889a8e0660bda..c83b7be08bd0a440778c52a79f61683e9c4a1893 100644 |
--- a/sdch/BUILD.gn |
+++ b/sdch/BUILD.gn |
@@ -6,6 +6,23 @@ config("sdch_config") { |
include_dirs = [ "open-vcdiff/src" ] |
} |
+# gn orders flags on a target before flags from configs. The default config |
+# adds -Wall, and these flags have to be after -Wall -- so they need to come |
+# from a config and can't be on the target directly. |
+config("sdch_warnings") { |
+ cflags = [] |
+ if (is_linux) { |
+ # TODO(mostynb): remove this if open-vcdiff is ever updated for c++11: |
+ cflags += [ "-Wno-deprecated-declarations" ] |
+ } |
+ |
+ if (is_clang) { |
+ # sdch uses the pre-c++11 typedef-as-static_assert hack. |
+ # https://code.google.com/p/open-vcdiff/issues/detail?id=44 |
+ cflags += [ "-Wno-unused-local-typedef" ] |
+ } |
+} |
+ |
static_library("sdch") { |
sources = [ |
"logging_forward.h", |
@@ -49,22 +66,6 @@ static_library("sdch") { |
"//third_party/zlib", |
] |
- # gn orders flags on a target before flags from configs. The default config |
- # adds -Wall, and these flags have to be after -Wall -- so they need to come |
- # from a config and can't be on the target directly. |
- config("sdch_warnings") { |
- cflags = [] |
- if (is_linux) { |
- # TODO(mostynb): remove this if open-vcdiff is ever updated for c++11: |
- cflags += [ "-Wno-deprecated-declarations" ] |
- } |
- |
- if (is_clang) { |
- # sdch uses the pre-c++11 typedef-as-static_assert hack. |
- # https://code.google.com/p/open-vcdiff/issues/detail?id=44 |
- cflags += [ "-Wno-unused-local-typedef" ] |
- } |
- } |
configs += [ ":sdch_warnings" ] |
if (is_linux || is_android) { |