Fix summary detection of cycles via redirect/super arguments.

pkg/analyzer/lib/src/summary/link.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This library is capable of producing linked summaries from unlinked
  * ones (or prelinked ones).  It functions by building a miniature
  * element model to represent the contents of the summaries, and then
  * scanning the element model to gather linked information and adding
  * it to the summary data structures.
@@ skipping 632 matching lines @@
           ConstructorElementForLink constructor = constructorElement
               .enclosingElement
               .getContainedName(constructorInitializer.name)
               .asConstructor;
           safeAddDependency(constructor?._constNode);
         }
         CompilationUnitElementForLink compilationUnit =
             constructorElement.enclosingElement.enclosingElement;
         collectDependencies(
             dependencies, constructorInitializer.expression, compilationUnit);
-        constructorInitializer.arguments.map((UnlinkedConst unlinkedConst) =>
-            collectDependencies(dependencies, unlinkedConst, compilationUnit));
+        for (UnlinkedConst unlinkedConst in constructorInitializer.arguments) {
+          collectDependencies(dependencies, unlinkedConst, compilationUnit);
+        }
       }
 
       if (defaultSuperInvocationNeeded) {
         // No explicit superconstructor invocation found, so we need to
         // manually insert a reference to the implicit superconstructor.
         if (superClass != null && !superClass.isObject) {
           ConstructorElementForLink unnamedConstructor =
               superClass.unnamedConstructor;
           safeAddDependency(unnamedConstructor?._constNode);
         }
@@ skipping 937 matching lines @@
 
   /**
    * Throw away any information produced by a previous call to [link].
    */
   void unlink() {
     for (LibraryElementInBuildUnit library in _librariesInBuildUnit) {
       library.unlink();
     }
   }
 }