Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1841833004: Fix morphing of files-toggle-ripple by passing proper property names to Animation API. (Closed)

Created:
4 years, 8 months ago by fukino
Modified:
4 years, 8 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix morphing of files-toggle-ripple by passing proper property names to Animation API. BUG=599286 TEST=manually Committed: https://crrev.com/f4f01ec7e01d008e69cef8f298595f8b1e61e439 Cr-Commit-Position: refs/heads/master@{#384197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ui/file_manager/file_manager/foreground/elements/files_toggle_ripple.js View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
fukino
PTAL. Thanks!
4 years, 8 months ago (2016-03-31 00:21:20 UTC) #2
yawano
lgtm. Thank you!
4 years, 8 months ago (2016-03-31 02:19:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841833004/1
4 years, 8 months ago (2016-03-31 04:38:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/196792)
4 years, 8 months ago (2016-03-31 05:45:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841833004/1
4 years, 8 months ago (2016-03-31 05:55:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 06:04:44 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 06:06:03 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f4f01ec7e01d008e69cef8f298595f8b1e61e439
Cr-Commit-Position: refs/heads/master@{#384197}

Powered by Google App Engine
This is Rietveld 408576698