third_party/WebKit/Source/web/PageWidgetDelegate.cpp - Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PageWidgetDelegate.cpp

Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't end recording twice in DrawingRecorder. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp ('K') | « third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/PageWidgetDelegate.cpp

diff --git a/third_party/WebKit/Source/web/PageWidgetDelegate.cpp b/third_party/WebKit/Source/web/PageWidgetDelegate.cpp

index e2c41392f90da57f9594eb456f320a8d51b081f9..38d2b90e8cc963ebf75f39732bebae55c72875ed 100644

--- a/third_party/WebKit/Source/web/PageWidgetDelegate.cpp

+++ b/third_party/WebKit/Source/web/PageWidgetDelegate.cpp

@@ -93,7 +93,9 @@ static void paintInternal(Page& page, WebCanvas* canvas,

paintContext.fillRect(dirtyRect, Color::white);

}

- pictureBuilder.endRecording()->playback(canvas);

+ RefPtr<const SkPicture> recording = pictureBuilder.endRecording();

+ if (recording)

+ recording->playback(canvas);

}

void PageWidgetDelegate::paint(Page& page, WebCanvas* canvas,