third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp - Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp

Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't end recording twice in DrawingRecorder. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp ('K') | « third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp ('k') | third_party/WebKit/Source/platform/graphics/GraphicsContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp b/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp

index 5a1b25147f3bbf1f335b6ee5fcb8694eec06d51a..d74b90d51c43695124f27680b3d45e29f8bbb4d2 100644

--- a/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp

+++ b/third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp

@@ -48,6 +48,8 @@ void GeneratedImage::drawPattern(GraphicsContext& destContext, const FloatRect&

builder.context().beginRecording(tileRect);

drawTile(builder.context(), srcRect);

RefPtr<SkPicture> tilePicture = builder.endRecording();

+ if (!tilePicture)

+ return;

AffineTransform patternTransform;

patternTransform.translate(phase.x(), phase.y());